[ET-VK][EZ] Rename to max_pool2d.yaml#2820
Closed
junpi3 wants to merge 2 commits intogh/jorgep31415/38/basefrom
Closed
[ET-VK][EZ] Rename to max_pool2d.yaml#2820junpi3 wants to merge 2 commits intogh/jorgep31415/38/basefrom
junpi3 wants to merge 2 commits intogh/jorgep31415/38/basefrom
Conversation
As @SSJia mentioned in the next change, we are following a convention where glsl and yaml files have a 1:1 mapping. To make the mapping clear, files should use the same name so `pool.yaml` should actually be `max_pool2d.yaml` to match `max_pool2d.glsl`. Differential Revision: [D55670408](https://our.internmc.facebook.com/intern/diff/D55670408/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2820
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9e49e9e with merge base d3326a2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55670408 |
copyrightly
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Closed
As ssjia mentioned in the next change, we are following a convention where glsl and yaml files have a 1:1 mapping. To make the mapping clear, files should use the same name so `pool.yaml` should actually be `max_pool2d.yaml` to match `max_pool2d.glsl`. Differential Revision: [D55670408](https://our.internmc.facebook.com/intern/diff/D55670408/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55670408 |
Contributor
|
This pull request has been merged in 9c9d2d7. |
Closed
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#2820 As @SSJia mentioned in the next change, we are following a convention where glsl and yaml files have a 1:1 mapping. To make the mapping clear, files should use the same name so `pool.yaml` should actually be `max_pool2d.yaml` to match `max_pool2d.glsl`. ghstack-source-id: 221721756 @exported-using-ghexport Differential Revision: [D55670408](https://our.internmc.facebook.com/intern/diff/D55670408/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
As ssjia mentioned in the next change, we are following a convention where glsl and yaml files have a 1:1 mapping. To make the mapping clear, files should use the same name so `pool.yaml` should actually be `max_pool2d.yaml` to match `max_pool2d.glsl`. Differential Revision: [D55670408](https://our.internmc.facebook.com/intern/diff/D55670408/) ghstack-source-id: 221058403 Pull Request resolved: pytorch/executorch#2820
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As @SSJia mentioned in the next change, we are following a convention where glsl and yaml files have a 1:1 mapping. To make the mapping clear, files should use the same name so
pool.yamlshould actually bemax_pool2d.yamlto matchmax_pool2d.glsl.Differential Revision: D55670408