fix et-view#2843

Closed

metascroy wants to merge 1 commit intopytorch:mainfrom

metascroy:export-D55715318

Contributor

metascroy commented Apr 3, 2024

Summary: et-view should always copy the data pointer.

Differential Revision: D55715318

pytorch-bot Bot commented Apr 3, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2843

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 712544d with merge base e641ffc ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Apr 3, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

facebook-github-bot added the fb-exported label

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

6a4355b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

1dae308

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 95a710b to 0127034 Compare

April 8, 2024 18:40

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

fa5dd42

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

ff34696

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 0127034 to ff34696 Compare

April 8, 2024 21:47

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

7a8b58e

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from ff34696 to 7a8b58e Compare

April 8, 2024 21:47

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

1 similar comment

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

6a47302

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

5fecf04

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 7a8b58e to da9f35f Compare

April 9, 2024 17:38

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

da9f35f

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

Contributor

facebook-github-bot commented Apr 9, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

37f9795

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

4dfad81

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

dce1b7b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

2a8aafa

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from da9f35f to 2a8aafa Compare

April 9, 2024 19:04

Contributor

facebook-github-bot commented Apr 9, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 2a8aafa to 849f9bf Compare

April 9, 2024 20:18

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

849f9bf

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 3e0c9da to 3628a5e Compare

April 10, 2024 18:31

Contributor

facebook-github-bot commented Apr 10, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

c9cc532

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

6eff977

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

405d145

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

686718f

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

26d506b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

8cf72a9

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

8d5b258

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

a64fe2d

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

8b36844

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

41dcbdd

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

69c01ff

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

1b294d3

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

305cb77

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

f7dc0ce

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

b4bc98c

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

f38804f

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

e0b0759

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

5d4d83b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

c2f157b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

09a37d1

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

2 similar comments

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318


          fix et-view (pytorch#2843)

712544d

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

JacobSzwejbka approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request has been merged in 1f6f711.

mergennachin mentioned this pull request

disclaimer #3376

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged