oss: Add buck_build cfg#2902
Closed
JakobDegen wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2902
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5cb3db6 with merge base 599cfde ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55791957 |
JakobDegen
force-pushed
the
export-D55791957
branch
from
6183633 to
e4fdd39
Compare
JakobDegen
added a commit
to JakobDegen/executorch
that referenced
this pull request
Apr 7, 2024
Summary: I'd like a simple way to check whether a build is using cargo or buck. Unfortunately, that doesn't exist right now. I suggest replacing the `buck_oss_build` cfg with a simpler `buck_build` cfg. This will be set internally via package files and externally via the OSS shim. (TBD: Should we set it in the macros internally too?) People can still recover the `#[cfg(buck_oss_build)]` behavior by checking `#[cfg(all(fbcode_build, buck_build))]`. Also, this diff cleans up some linter overrides via `prelude = native` Reviewed By: dtolnay Differential Revision: D55791957
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55791957 |
JakobDegen
added a commit
to JakobDegen/executorch
that referenced
this pull request
Apr 7, 2024
Summary: I'd like a simple way to check whether a build is using cargo or buck. Unfortunately, that doesn't exist right now. I suggest replacing the `buck_oss_build` cfg with a simpler `buck_build` cfg. This will be set internally via package files and externally via the OSS shim. (TBD: Should we set it in the macros internally too?) People can still recover the `#[cfg(buck_oss_build)]` behavior by checking `#[cfg(all(fbcode_build, buck_build))]`. Also, this diff cleans up some linter overrides via `prelude = native` Reviewed By: dtolnay Differential Revision: D55791957
JakobDegen
force-pushed
the
export-D55791957
branch
from
e4fdd39 to
34927b2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55791957 |
kit1980
approved these changes
Apr 8, 2024
Summary: I'd like a simple way to check whether a build is using cargo or buck. Unfortunately, that doesn't exist right now. I suggest replacing the `buck_oss_build` cfg with a simpler `buck_build` cfg. This will be set internally via package files and externally via the OSS shim. (TBD: Should we set it in the macros internally too?) People can still recover the `#[cfg(buck_oss_build)]` behavior by checking `#[cfg(all(fbcode_build, buck_build))]`. Also, this diff cleans up some linter overrides via `prelude = native` Reviewed By: dtolnay Differential Revision: D55791957
JakobDegen
force-pushed
the
export-D55791957
branch
from
34927b2 to
5cb3db6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55791957 |
Contributor
Author
|
@pytorchbot merge |
Contributor
|
This pull request has been merged in c4054f1. |
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Apr 9, 2024
Summary: X-link: pytorch/executorch#2902 I'd like a simple way to check whether a build is using cargo or buck. Unfortunately, that doesn't exist right now. I suggest replacing the `buck_oss_build` cfg with a simpler `buck_build` cfg. This will be set internally via package files and externally via the OSS shim. (TBD: Should we set it in the macros internally too?) People can still recover the `#[cfg(buck_oss_build)]` behavior by checking `#[cfg(all(fbcode_build, buck_build))]`. Also, this diff cleans up some linter overrides via `prelude = native` Reviewed By: dtolnay Differential Revision: D55791957 fbshipit-source-id: 1a411ce0ad831015cf55f8722512490e33d77454
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Apr 9, 2024
Summary: X-link: pytorch/executorch#2902 I'd like a simple way to check whether a build is using cargo or buck. Unfortunately, that doesn't exist right now. I suggest replacing the `buck_oss_build` cfg with a simpler `buck_build` cfg. This will be set internally via package files and externally via the OSS shim. (TBD: Should we set it in the macros internally too?) People can still recover the `#[cfg(buck_oss_build)]` behavior by checking `#[cfg(all(fbcode_build, buck_build))]`. Also, this diff cleans up some linter overrides via `prelude = native` Reviewed By: dtolnay Differential Revision: D55791957 fbshipit-source-id: 1a411ce0ad831015cf55f8722512490e33d77454
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I'd like a simple way to check whether a build is using cargo or buck. Unfortunately, that doesn't exist right now.
I suggest replacing the
buck_oss_buildcfg with a simplerbuck_buildcfg. This will be set internally via package files and externally via the OSS shim. (TBD: Should we set it in the macros internally too?)People can still recover the
#[cfg(buck_oss_build)]behavior by checking#[cfg(all(fbcode_build, buck_build))].Also, this diff cleans up some linter overrides via
prelude = nativeReviewed By: dtolnay
Differential Revision: D55791957