Use new API to register custom ops for llama model#2916
Closed
larryliu0820 wants to merge 1 commit intopytorch:mainfrom
Closed
Use new API to register custom ops for llama model#2916larryliu0820 wants to merge 1 commit intopytorch:mainfrom
larryliu0820 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2916
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 371a5e8 with merge base 7d4bafc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 8, 2024
Summary: Retry of D55713944 Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
b5d9e5a to
db449f3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 8, 2024
Summary: Retry of D55713944 Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
db449f3 to
3b385c4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 8, 2024
Summary: Retry of D55713944 Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
3b385c4 to
6b5a8dc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
force-pushed
the
export-D55856491
branch
from
6b5a8dc to
8f72f80
Compare
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 9, 2024
Summary: Retry of D55713944 Differential Revision: D55856491
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 9, 2024
Summary: Retry of D55713944 Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
8f72f80 to
37aa318
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 9, 2024
Summary: Retry of D55713944 Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
37aa318 to
ab6f19a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Retry of D55713944 Use `EXECUTORCH_LIBRARY` to register custom kernel to ExecuTorch runtime. Differential Revision: D55856491
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: #2916 Retry of D55713944 Differential Revision: D55856491
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: pytorch#2916 Retry of D55713944 Use `EXECUTORCH_LIBRARY` to register custom kernel to ExecuTorch runtime. Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
ab6f19a to
c687856
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Retry of D55713944 Use `EXECUTORCH_LIBRARY` to register custom kernel to ExecuTorch runtime. Differential Revision: D55856491
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: #2916 Retry of D55713944 Differential Revision: D55856491
larryliu0820
added a commit
to larryliu0820/executorch-2
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: pytorch#2916 Retry of D55713944 Use `EXECUTORCH_LIBRARY` to register custom kernel to ExecuTorch runtime. Reviewed By: lucylq Differential Revision: D55856491
larryliu0820
force-pushed
the
export-D55856491
branch
from
aefc3fc to
f30f768
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
added a commit
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: #2916 Retry of D55713944 Differential Revision: D55856491
Summary: Pull Request resolved: pytorch#2916 Retry of D55713944 Use `EXECUTORCH_LIBRARY` to register custom kernel to ExecuTorch runtime. Reviewed By: lucylq Differential Revision: D55856491
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55856491 |
larryliu0820
force-pushed
the
export-D55856491
branch
from
f30f768 to
371a5e8
Compare
larryliu0820
added a commit
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: #2916 Retry of D55713944 Differential Revision: D55856491
larryliu0820
added a commit
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: #2916 Retry of D55713944 Differential Revision: D55856491
lucylq
approved these changes
Apr 11, 2024
Contributor
|
This pull request has been merged in 6e43135. |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
* Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML.
Closed
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
* Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
Summary: * Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in pytorch#2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: pytorch#3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba)
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * [NOT APPLICABLE IN RELEASE] Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in pytorch#2916 so need to remove it from `build_apple_frameworks.sh`. * [NOT APPLICABLE IN RELEASE] Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: pytorch#3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba)
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * [NOT APPLICABLE IN RELEASE] Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in pytorch#2916 so need to remove it from `build_apple_frameworks.sh`. * [NOT APPLICABLE IN RELEASE] Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: pytorch#3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba)
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * [NOT APPLICABLE IN RELEASE] Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in pytorch#2916 so need to remove it from `build_apple_frameworks.sh`. * [NOT APPLICABLE IN RELEASE] Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: pytorch#3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba)
guangy10
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add executorch_no_prim_ops target (#2934) Summary: Pull Request resolved: #2934 Currently `libexecutorch.a` always contain prim ops. This becomes a problem when a binary contains 2 "versions" of `libexecutorch.a`, causing a double registration of the prim ops. For example, `libA.so` depends on `libexecutorch.a` and a binary `B` depends on both `libA.so` and `libexecutorch.a`. Since both `libexecutorch.a` and `libA.so` contains prim ops, they will be registered twice. In this PR I created another library `executorch_no_prim_ops` for `libA.so` to depend on. Reviewed By: cccclai, kirklandsign Differential Revision: D55907752 fbshipit-source-id: 755a9b8d5f6f7cf44d011b83bfdc18be6da1aa05 (cherry picked from commit d309e9d) * Fix failing CI jobs caused by #2934 (#2961) Summary: Pull Request resolved: #2961 Fix these 3 CI job failures caused by #2934 (D55907752): * Apple / build-frameworks-ios / macos-job * trunk / test-arm-backend-delegation / linux-job * trunk / test-coreml-delegate / macos-job Reviewed By: kirklandsign Differential Revision: D55950023 fbshipit-source-id: 6166d9112e6d971d042df1400442395d8044c3b3 (cherry picked from commit d993797) * [NOT-CLEAN-CP] Fix 3 CI jobs (#3006) Summary: * [NOT APPLICABLE IN RELEASE] Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * [NOT APPLICABLE IN RELEASE] Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba) --------- Co-authored-by: Mengwei Liu <larryliu@meta.com> Co-authored-by: Mengwei Liu <larryliu@fb.com>
huydhn
pushed a commit
that referenced
this pull request
Apr 21, 2024
Summary: * Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec
pytorchbot
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: * Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec (cherry picked from commit 5b7c4ba)
Closed
huydhn
added a commit
that referenced
this pull request
Apr 22, 2024
* Fix build-framework-ios CI job (#2996) Summary: As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not able to copy generated headers `program_generated.h` and `scalar_type_generated.h`. This PR fixes it by moving it back to `deps`. Pull Request resolved: #2996 Reviewed By: kirklandsign Differential Revision: D56028952 Pulled By: larryliu0820 fbshipit-source-id: 2cd4999154877b0ac7b49cd1f54d518cba34b2f2 * Fix 3 CI jobs (#3006) Summary: * Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec * Revert "Fix build-framework-ios CI job (#2996)" This reverts commit e365c5b. --------- Co-authored-by: Mengwei Liu <larryliu@fb.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Retry of D55713944
Differential Revision: D55856491