Consolidate EXECUTORCH_BUILD_CUSTOM option#2935
Closed
larryliu0820 wants to merge 2 commits intomainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2935
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit adc04ba with merge base 554cd27 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. Differential Revision: D55907750
facebook-github-bot
force-pushed
the
export-D55907750
branch
from
e313a29 to
f634ed8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
larryliu0820
added a commit
that referenced
this pull request
Apr 9, 2024
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. Differential Revision: D55907750
larryliu0820
force-pushed
the
export-D55907750
branch
from
f634ed8 to
6ef104a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
larryliu0820
added a commit
that referenced
this pull request
Apr 9, 2024
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. Differential Revision: D55907750
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. Differential Revision: D55907750
facebook-github-bot
force-pushed
the
export-D55907750
branch
from
6ef104a to
5ed091c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. Differential Revision: D55907750
facebook-github-bot
force-pushed
the
export-D55907750
branch
from
5ed091c to
323324a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
lucylq
approved these changes
Apr 10, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. Reviewed By: lucylq Differential Revision: D55907750
facebook-github-bot
force-pushed
the
export-D55907750
branch
from
323324a to
b440523
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. bypass-github-pytorch-ci-checks bypass-export-ci-checks Reviewed By: lucylq Differential Revision: D55907751
Summary: Currently `EXECUTORCH_BUILD_CUSTOM` is not being respected properly. If this option is false, we should not build `llama2/custom_ops` anywhere. If this option is true, we should build `llama2/custom_ops` in both llama runner binary and pybind. This PR consolidates it. bypass-github-pytorch-ci-checks bypass-export-ci-checks Reviewed By: lucylq Differential Revision: D55907750
larryliu0820
force-pushed
the
export-D55907750
branch
from
b440523 to
adc04ba
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55907750 |
Contributor
|
This pull request has been merged in d209e41. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently
EXECUTORCH_BUILD_CUSTOMis not being respected properly.If this option is false, we should not build
llama2/custom_opsanywhere.If this option is true, we should build
llama2/custom_opsin both llama runner binary and pybind.This PR consolidates it.
Differential Revision: D55907750