remove duplicate generate_lib_aten target under aten kernel#2951
Closed
Gasoonjia wants to merge 1 commit intopytorch:mainfrom
Closed
remove duplicate generate_lib_aten target under aten kernel#2951Gasoonjia wants to merge 1 commit intopytorch:mainfrom
Gasoonjia wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2951
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit ef991ab with merge base d209e41 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55937122 |
3a5be6b to
eb074ad
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Apr 10, 2024
…2951) Summary: generate_lib and generate_lib_aten are exactly the same under executorch/kernels/aten. Remove the generate_lib_aten for better understanding. Differential Revision: D55937122
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55937122 |
larryliu0820
approved these changes
Apr 10, 2024
…2951) Summary: generate_lib and generate_lib_aten are exactly the same under executorch/kernels/aten. Remove the generate_lib_aten for better understanding. Reviewed By: larryliu0820 Differential Revision: D55937122
eb074ad to
ef991ab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55937122 |
Contributor
|
This pull request has been merged in 075fe40. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: generate_lib and generate_lib_aten are exactly the same under executorch/kernels/aten. Remove the generate_lib_aten for better understanding.
Differential Revision: D55937122