Fix tutorial for Qualcomm AI Engine Direct Backend by kirklandsign · Pull Request #2956 · pytorch/executorch

kirklandsign · 2024-04-09T23:58:07Z

We have refactors recently and need to update the tutorial and cmake.

See #2955 for isseues.

We have refactors recently and need to update the tutorial and cmake

pytorch-bot · 2024-04-09T23:58:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2956

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b152bbc with merge base b26eee8 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-04-09T23:59:14Z

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cccclai · 2024-04-10T00:11:30Z

    qnn_schema
    qnn_manager
-    executorch
+    executorch_no_prim_ops


how do we link it with prim ops lib?

In

executorch/examples/qualcomm/CMakeLists.txt

Lines 102 to 108 in 687425d

target_link_libraries(qnn_executor_runner

qnn_executorch_backend

full_portable_ops_lib

etdump

${FLATCCRT_LIB}

gflags

)

, maybe full_portable_ops_lib has it… Otherwise we need to add executorch explicitly

For other users, add executorch explicitly to binary helps

TLDR is for users who use qnn_executorch_backend as a dependency, it should also have executorch as a dependency now.

cccclai · 2024-04-10T00:11:58Z

+mkdir cmake_android_out
+cd cmake_android_out


why this change is needed?

can use old one. simply it's already in gitignore.

let's use the old one probably? Try to make the change minimum

facebook-github-bot · 2024-04-10T03:37:05Z

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cccclai · 2024-04-10T03:54:21Z

@chiwwang can you help with tagging reviewers?

chiwwang · 2024-04-10T04:00:35Z

Hey @chuntl , may I know if you're able to give this a try?

chuntl · 2024-04-10T06:51:15Z

Rebase to mainline and do the "./install_requirements.sh“ meet the target missing issue:

It seems there're some WIP PRs to fix the CI issue and affect to test this PR.

chiwwang · 2024-04-10T07:01:32Z

Rebase to mainline and do the "./install_requirements.sh“ meet the target missing issue:

It seems there're some WIP PRs to fix the CI issue and affect to test this PR.

Got it.
Assuming this error will be fixed, if the content of this PR looks good?

chuntl · 2024-04-10T07:13:35Z

Rebase to mainline and do the "./install_requirements.sh“ meet the target missing issue:

It seems there're some WIP PRs to fix the CI issue and affect to test this PR.

Got it. Assuming this error will be fixed, if the content of this PR looks good?

Yes, It looks good to me. But it's better to double-check after the error fixed.

chiwwang · 2024-04-10T09:02:12Z

-    -DBUCK2=buck2 \
    -DCMAKE_INSTALL_PREFIX=$PWD \
+    -DEXECUTORCH_BUILD_SDK=ON \
    -DEXECUTORCH_BUILD_QNN=ON \


Possibly need something like CMAKE_INSTALL_PREFIX if we don't want to require root priviledge.
mmmm... would it be a good idea to leave a reminder here?

kirklandsign · 2024-04-10T17:22:37Z

Rebase to mainline and do the "./install_requirements.sh“ meet the target missing issue:

It seems there're some WIP PRs to fix the CI issue and affect to test this PR.

Since we updated https://github.com/pytorch/executorch/blob/main/build/cmake_deps.toml, we need to rm -rf pip-out. We will note this in the doc.

chuntl · 2024-04-11T01:33:03Z

This PR looks good to me, thank you!

facebook-github-bot · 2024-04-11T18:13:59Z

@kirklandsign merged this pull request in c7fd394.

Summary: We have refactors recently and need to update the tutorial and cmake. See pytorch#2955 for isseues. Pull Request resolved: pytorch#2956 Reviewed By: mcr229, cccclai Differential Revision: D55947725 Pulled By: kirklandsign fbshipit-source-id: f23af28b9a8fe071223d8ffa922a6cd4e49efe61 (cherry picked from commit c7fd394)

Summary: We have refactors recently and need to update the tutorial and cmake. See #2955 for isseues. Pull Request resolved: #2956 Reviewed By: mcr229, cccclai Differential Revision: D55947725 Pulled By: kirklandsign fbshipit-source-id: f23af28b9a8fe071223d8ffa922a6cd4e49efe61 (cherry picked from commit c7fd394)

Fix tutorial for Qualcomm AI Engine Direct Backend

687425d

We have refactors recently and need to update the tutorial and cmake

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024

kirklandsign assigned cccclai Apr 9, 2024

kirklandsign requested a review from cccclai April 9, 2024 23:58

kirklandsign added the partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm label Apr 9, 2024

cccclai reviewed Apr 10, 2024

View reviewed changes

Make minimal changes

b152bbc

kirklandsign mentioned this pull request Apr 10, 2024

Android demo app tutorial fix for XNNPACK and QNN #2962

Closed

chiwwang reviewed Apr 10, 2024

View reviewed changes

chuntl approved these changes Apr 11, 2024

View reviewed changes

cccclai approved these changes Apr 11, 2024

View reviewed changes

facebook-github-bot closed this in c7fd394 Apr 11, 2024

facebook-github-bot added the Merged label Apr 11, 2024

kirklandsign mentioned this pull request Apr 11, 2024

[v0.2.0] Release Tracker #2666

Closed

kirklandsign mentioned this pull request Apr 12, 2024

Fix tutorial for Qualcomm AI Engine Direct Backend (#2956) #3026

Merged

This was referenced Apr 25, 2024

fix llama readme #3339

Closed

disclaimer #3376

Closed

	target_link_libraries(qnn_executor_runner
	qnn_executorch_backend
	full_portable_ops_lib
	etdump
	${FLATCCRT_LIB}
	gflags
	)

Conversation

kirklandsign commented Apr 9, 2024

Uh oh!

pytorch-bot Bot commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2956

✅ No Failures

Uh oh!

facebook-github-bot commented Apr 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 10, 2024

Uh oh!

cccclai commented Apr 10, 2024

Uh oh!

chiwwang commented Apr 10, 2024

Uh oh!

chuntl commented Apr 10, 2024

Uh oh!

chiwwang commented Apr 10, 2024

Uh oh!

chuntl commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirklandsign commented Apr 10, 2024

Uh oh!

chuntl commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pytorch-bot Bot commented Apr 9, 2024 •

edited

Loading

chuntl commented Apr 10, 2024 •

edited

Loading

chuntl commented Apr 11, 2024 •

edited

Loading