Decouple custom ops in llama_transformer.py Part 2/N#3007
Closed
mergennachin wants to merge 2 commits intopytorch:mainfrom
Closed
Decouple custom ops in llama_transformer.py Part 2/N#3007mergennachin wants to merge 2 commits intopytorch:mainfrom
mergennachin wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3007
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit fbd4d36 with merge base 6acc86f ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56048640 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56048640 |
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: pytorch#3007 Keep llama_transformer.py to look like stock implementation, so that it can be reused everywhere. Do module swap Differential Revision: D56048640
mergennachin
force-pushed
the
export-D56048640
branch
from
93bed84 to
3b0c813
Compare
Summary: This is a no-op Pull Request resolved: pytorch#3005 Test Plan: CI Run with `python -m examples.models.llama2.export_llama -c stories110M.pt -p params.json -kv --use_sdpa_with_kv_cache -X` and with `python -m examples.models.llama2.export_llama -c stories110M.pt -p params.json -kv -X` Make sure both work Differential Revision: D56048177 Pulled By: mergennachin
Summary: Pull Request resolved: pytorch#3007 Keep llama_transformer.py to look like stock implementation, so that it can be reused everywhere. Do module swap Differential Revision: D56048640
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56048640 |
mergennachin
force-pushed
the
export-D56048640
branch
from
3b0c813 to
fbd4d36
Compare
cccclai
approved these changes
Apr 12, 2024
Contributor
|
This pull request has been merged in 74eb8b3. |
cccclai
pushed a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 16, 2024
Summary: Pull Request resolved: pytorch#3007 Keep llama_transformer.py to look like stock implementation, so that it can be reused everywhere. Do module swap Reviewed By: cccclai Differential Revision: D56048640 fbshipit-source-id: 76de1b09b7f5d79422bb3b32bc830a9a7ecd935c (cherry picked from commit 74eb8b3)
guangy10
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: Pull Request resolved: #3007 Keep llama_transformer.py to look like stock implementation, so that it can be reused everywhere. Do module swap Reviewed By: cccclai Differential Revision: D56048640 fbshipit-source-id: 76de1b09b7f5d79422bb3b32bc830a9a7ecd935c (cherry picked from commit 74eb8b3) Co-authored-by: Mergen Nachin <mnachin@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep llama_transformer.py to look like stock implementation, so that it can be reused everywhere.
Do module swap
Differential Revision: D56048640