[ET-VK][EZ] Throw in VK_GET_OP_FN if op is not found#3028
Closed
junpi3 wants to merge 1 commit intogh/jorgep31415/50/basefrom
Closed
[ET-VK][EZ] Throw in VK_GET_OP_FN if op is not found#3028junpi3 wants to merge 1 commit intogh/jorgep31415/50/basefrom
junpi3 wants to merge 1 commit intogh/jorgep31415/50/basefrom
Conversation
Make @yipjustin happy. Forgot this safeguard when I originally wrote the `OperatorRegistry` class. Differential Revision: [D56085588](https://our.internmc.facebook.com/intern/diff/D56085588/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3028
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 66afb96 with merge base 5b7c4ba ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
junpi3
pushed a commit
that referenced
this pull request
Apr 12, 2024
Make yipjustin happy. Forgot this safeguard when I originally wrote the `OperatorRegistry` class. Differential Revision: [D56085588](https://our.internmc.facebook.com/intern/diff/D56085588/) ghstack-source-id: 222384998 Pull Request resolved: #3028
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56085588 |
SS-JIA
approved these changes
Apr 12, 2024
Contributor
|
This pull request has been merged in 4d7dd03. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Make @yipjustin happy. Forgot this safeguard when I originally wrote the
OperatorRegistryclass.Differential Revision: D56085588