Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3030
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 9a4c1f6 with merge base 7616d42 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
force-pushed
the
lfq.generation-kv-cache-2
branch
from
00e9159 to
5c98ea6
Compare
Contributor
|
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lucylq
force-pushed
the
lfq.generation-kv-cache-2
branch
from
5c98ea6 to
b48bfd1
Compare
Contributor
|
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Apr 15, 2024
Contributor
larryliu0820
left a comment
larryliu0820
left a comment
There was a problem hiding this comment.
Lint? Also does this work with our current model? Llama2 and stories
Summary:
python e2e generation, using tiktoken tokenizer.
using text_completion, haven't tried chat_completion.
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
Command, with prompt "Hello, I am" and seq_len = 10
```
python -m examples.models.llama2.runner.generation --pte llama_4ckpts_x.pte --tokenizer tokenizer.model --prompt="Hello I am" --temperature=0 --params ../llama-models/llama3/params_less.json --max_gen_len=10
```
fp32, xnn, kv
fp32, xnn
same results:
```
Result: [{'generation': ' a 25 year old woman. I am a'}]
```
fp32, xnn, int4
```
Result: [{'generation': ' interested in the following products: - 1 x'}]
```
fp32, xnn, kv, sdpa (need investigation)
```
Result: [{'generation': 'ฉopteraenthalenthalenthalenthalenthalenthalenthalenthal'}]
```
Reviewed By: larryliu0820
Differential Revision: D56087430
Pulled By: lucylq
facebook-github-bot
force-pushed
the
lfq.generation-kv-cache-2
branch
from
b48bfd1 to
9a4c1f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56087430 |
Contributor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.