Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3041
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 88d244f with merge base 057e432 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56139927 |
facebook-github-bot
added
CLA Signed
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
Apr 15, 2024
Summary: We are updating to clang-formatter 18. The current clang-format in coreml code has duplicate key. Deleting one of them. Differential Revision: D56139927
mergennachin
force-pushed
the
export-D56139927
branch
from
33ef245 to
fed1270
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56139927 |
mergennachin
commented
Apr 15, 2024
| @@ -1,5 +1,4 @@ | |||
| BasedOnStyle: WebKit | |||
| BreakBeforeBraces: Attach | |||
Contributor
Author
There was a problem hiding this comment.
@cymbalrush BreakBeforeBraces was defined twice in this class. With the new clang-format 18, it doesn't allow to have duplicate keys.
Deleting one of them
Contributor
Author
There was a problem hiding this comment.
Here's an example error when running lintrunner
Advice (CLANGFORMAT) command-failed
COMMAND (exit code 1)
/home/mnachin/local/miniconda3/envs/executorch_docs/bin/clang-format
-style=file /data/users/mnachin/fbsource/fbcode/executorch/backends/apple/
coreml/runtime/util/objc_safe_cast.h
STDERR
/data/users/mnachin/fbsource/fbcode/executorch/backends/
apple/coreml/.clang-format:23:1: error: duplicated mapping key
'BreakBeforeBraces'
BreakBeforeBraces: Custom
^~~~~~~~~~~~~~~~~
Error reading /data/users/mnachin/fbsource/fbcode/executorch/backends/
apple/coreml/.clang-format: Invalid argument
STDOUT
(empty)
Summary: Pull Request resolved: pytorch#3041 We are updating to clang-formatter 18. The current clang-format in coreml code has duplicate key. Deleting one of them. Differential Revision: D56139927
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56139927 |
mergennachin
force-pushed
the
export-D56139927
branch
from
fed1270 to
88d244f
Compare
Contributor
|
This pull request has been merged in 7c81155. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We are updating to clang-formatter 18.
The current clang-format in coreml code has duplicate key. Deleting one of them. It didn't complain in the old clang-formatter 12
Differential Revision: D56139927