Fix test_llama_runner by hiding tiktoken#3055
Closed
larryliu0820 wants to merge 3 commits intogh/larryliu0820/26/basefrom
Closed
Fix test_llama_runner by hiding tiktoken#3055larryliu0820 wants to merge 3 commits intogh/larryliu0820/26/basefrom
larryliu0820 wants to merge 3 commits intogh/larryliu0820/26/basefrom
Conversation
Summary: We don't always want to build tiktoken dependencies (re2 and abseil) so this PR only build it if the option is on. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3055
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6e58ede with merge base 458d743 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iseeyuan
approved these changes
Apr 16, 2024
Summary: We don't always want to build tiktoken dependencies (re2 and abseil) so this PR only build it if the option is on. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56178928](https://our.internmc.facebook.com/intern/diff/D56178928) [ghstack-poisoned]
Contributor
Author
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: We don't always want to build tiktoken dependencies (re2 and abseil) so this PR only build it if the option is on. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56178928](https://our.internmc.facebook.com/intern/diff/D56178928) [ghstack-poisoned]
Contributor
Author
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in 473c98c. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: We don't always want to build tiktoken dependencies (re2 and
abseil) so this PR only build it if the option is on.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D56178928