[ET-VK] Enable additional specialization constants in compute shaders#3079
Closed
SS-JIA wants to merge 3 commits intogh/SS-JIA/37/basefrom
Closed
[ET-VK] Enable additional specialization constants in compute shaders#3079SS-JIA wants to merge 3 commits intogh/SS-JIA/37/basefrom
SS-JIA wants to merge 3 commits intogh/SS-JIA/37/basefrom
Conversation
## Context Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader. Differential Revision: [D56225042](https://our.internmc.facebook.com/intern/diff/D56225042/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3079
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7626b7b with merge base bae0387 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56225042 |
SS-JIA
added a commit
that referenced
this pull request
Apr 17, 2024
## Context Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader. Differential Revision: [D56225042](https://our.internmc.facebook.com/intern/diff/D56225042/) ghstack-source-id: 222806317 Pull Request resolved: #3079
…ute shaders" ## Context Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader. Differential Revision: [D56225042](https://our.internmc.facebook.com/intern/diff/D56225042/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56225042 |
SS-JIA
added a commit
that referenced
this pull request
Apr 17, 2024
Pull Request resolved: #3079 ## Context Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader. Differential Revision: [D56225042](https://our.internmc.facebook.com/intern/diff/D56225042/) ghstack-source-id: 222863752
junpi3
approved these changes
Apr 17, 2024
…ute shaders" ## Context Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader. Differential Revision: [D56225042](https://our.internmc.facebook.com/intern/diff/D56225042/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Apr 17, 2024
Pull Request resolved: #3079 ## Context Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader. ghstack-source-id: 222903463 Differential Revision: [D56225042](https://our.internmc.facebook.com/intern/diff/D56225042/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56225042 |
copyrightly
approved these changes
Apr 17, 2024
Contributor
|
This pull request has been merged in 78cb141. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
SpecVarListto represent specialization constants #3078Context
Building on top of the previous changeset in the stack, this changeset modifies shader dispatch APIs to accept additional specialization constants for a shader.
Differential Revision: D56225042