Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3081
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 74b78e7 with merge base 1f4b631 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56229021 |
larryliu0820
approved these changes
Apr 17, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
facebook-github-bot
force-pushed
the
export-D56229021
branch
from
8699dc9 to
2f18427
Compare
mikekgfb
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
mikekgfb
force-pushed
the
export-D56229021
branch
from
2f18427 to
b13d167
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56229021 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56229021 |
| self.weight, self.scales, None, 0, 0, indices, dtype=self.dtype | ||
| ) | ||
| else: # 4bit packed | ||
| return torch.ops.llama_quantized.embedding_4bit.dtype( |
Contributor
There was a problem hiding this comment.
It seems here it should be quantized_decomposed::embedding_4bit
|
|
||
| class EmbeddingOnlyInt8QuantHandler: | ||
| def __init__(self, mod, *, bitwidth: int = 8, group_size: Optional[int] = None): | ||
| class EmbeddingOnlyInt8QuantHandler(QuantHandler): |
Contributor
There was a problem hiding this comment.
Should we rename this class? Since it's not int8 only anymore.
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
facebook-github-bot
force-pushed
the
export-D56229021
branch
from
b13d167 to
74b78e7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56229021 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
mikekgfb
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
larryliu0820
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
larryliu0820
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
manuelcandales
approved these changes
Apr 18, 2024
larryliu0820
pushed a commit
that referenced
this pull request
Apr 18, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Apr 18, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
larryliu0820
pushed a commit
that referenced
this pull request
Apr 19, 2024
Summary: 4b embedding quantizer Reviewed By: larryliu0820 Differential Revision: D56229021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: 4b embedding quantizer
Differential Revision: D56229021