support emit sym value from delegate#3103
Closed
cccclai wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3103
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9198a14 with merge base 1eed125 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56176100 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 17, 2024
Summary: For dynamic shape, if delegate output is dynamic shape, the return might be something like `(s0, x, y)`, and `s0` is a sym type while others are fake tensor. In this case, we will emit the sym value (including `SymFloat`, `SymBool`, `SymInt`) to a unique Evalue. Since the sym type node will have an empty spec, we use the `node.meta['val']` to find out it's a sym type node. Differential Revision: D56176100
cccclai
force-pushed
the
export-D56176100
branch
from
6a3d314 to
09bc636
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56176100 |
Summary: For dynamic shape, if delegate output is dynamic shape, the return might be something like `(s0, x, y)`, and `s0` is a sym type while others are fake tensor. In this case, we will emit the sym value (including `SymFloat`, `SymBool`, `SymInt`) to a unique Evalue. Since the sym type node will have an empty spec, we use the `node.meta['val']` to find out it's a sym type node. Reviewed By: mcr229 Differential Revision: D56176100
cccclai
force-pushed
the
export-D56176100
branch
from
09bc636 to
9198a14
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56176100 |
mcr229
approved these changes
Apr 19, 2024
Contributor
|
This pull request has been merged in 73599f4. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For dynamic shape, if delegate output is dynamic shape, the return might be something like
(s0, x, y), ands0is a sym type while others are fake tensor. In this case, we will emit the sym value (includingSymFloat,SymBool,SymInt) to a unique Evalue.Since the sym type node will have an empty spec, we use the
node.meta['val']to find out it's a sym type node.Differential Revision: D56176100