cherry-pick: Add required deps to pyproject.toml#3117
Closed
Conversation
These pip dependencies need to be present to build the pip wheel. Also, change the version to a stub that looks less like a real version, until we can hook up the logic to get the version from the git repo state.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3117
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 2acd86b with merge base b19d586 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
commented
Apr 18, 2024
| # TODO(dbort): Use setuptools-git-versioning or setuptools-scm to get the | ||
| # version from the git branch state. For now, use a version that doesn't look | ||
| # like a real release. | ||
| version = "0.2.1.dev0+unknown" |
Contributor
Author
There was a problem hiding this comment.
I modified the cherry-pick to make this 0.2.1 since it's after the 0.2.0 release.
tugsbayasgalan
approved these changes
Apr 18, 2024
Contributor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick 28f1c8c from release/0.2 into main
These pip dependencies need to be present to build the pip wheel.
Also, change the version to a stub that looks less like a real version,
until we can hook up the logic to get the version from the git repo
state.