Enable doc upload for tags, disable for release branches#3153
Closed
Enable doc upload for tags, disable for release branches#3153
Conversation
- Disabled doc upload for branches like release/x.x
- Enabled publishing for tags.
Tested locally:
```
export GITHUB_REF=refs/tags/v3.1.4-rc5
```
bash test-version.py
```
# test-version.py
if [[ "${GITHUB_REF}" =~ ^refs/tags/v([0-9]+\.[0-9]+)\.* ]]; then
TARGET_FOLDER="${BASH_REMATCH[1]}"
else
TARGET_FOLDER="main"
fi
echo "Target folder: ${TARGET_FOLDER}"
```
Output:
```
Target folder: 3.1
```
One more:
```
export GITHUB_REF=refs/tags/v1.15.4
bash test-version.sh
```
Output:
```
Target folder: 1.15
```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3153
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ce8f01 with merge base 2c467dd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
clee2000
approved these changes
Apr 22, 2024
dbort
reviewed
Apr 22, 2024
Co-authored-by: Dave Bort <dbort@users.noreply.github.com>
svekars
commented
Apr 22, 2024
dbort
approved these changes
Apr 22, 2024
Contributor
dbort
left a comment
dbort
left a comment
There was a problem hiding this comment.
Thanks, that's much simpler.
Please import this into a phabricator diff to run internal testing so we can land it
Co-authored-by: Dave Bort <dbort@users.noreply.github.com>
Contributor
|
@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.2 -c docs |
Collaborator
Cherry picking #3153The cherry pick PR is at #3243 Details for Dev Infra teamRaised by workflow job |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary:
- Disabled doc upload for branches like release/x.x
- Enabled publishing for tags.
Tested locally:
```
export GITHUB_REF=refs/tags/v3.1.4-rc5
bash test-version.py
```
```
# test-version.py
if [[ "${GITHUB_REF}" =~ ^refs/tags/v([0-9]+\.[0-9]+)\.* ]]; then
TARGET_FOLDER="${BASH_REMATCH[1]}"
else
TARGET_FOLDER="main"
fi
echo "Target folder: ${TARGET_FOLDER}"
```
Output:
```
Target folder: 3.1
```
One more:
```
export GITHUB_REF=refs/tags/v1.15.4
bash test-version.sh
```
Output:
```
Target folder: 1.15
```
Pull Request resolved: #3153
Reviewed By: dbort
Differential Revision: D56445037
Pulled By: svekars
fbshipit-source-id: e7328523dfe308e8921c1e4f365d9a757d053191
(cherry picked from commit ee8c3a6)
guangy10
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary:
- Disabled doc upload for branches like release/x.x
- Enabled publishing for tags.
Tested locally:
```
export GITHUB_REF=refs/tags/v3.1.4-rc5
bash test-version.py
```
```
# test-version.py
if [[ "${GITHUB_REF}" =~ ^refs/tags/v([0-9]+\.[0-9]+)\.* ]]; then
TARGET_FOLDER="${BASH_REMATCH[1]}"
else
TARGET_FOLDER="main"
fi
echo "Target folder: ${TARGET_FOLDER}"
```
Output:
```
Target folder: 3.1
```
One more:
```
export GITHUB_REF=refs/tags/v1.15.4
bash test-version.sh
```
Output:
```
Target folder: 1.15
```
Pull Request resolved: #3153
Reviewed By: dbort
Differential Revision: D56445037
Pulled By: svekars
fbshipit-source-id: e7328523dfe308e8921c1e4f365d9a757d053191
(cherry picked from commit ee8c3a6)
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested locally:
Output:
One more:
Output: