Fix portable is[inf|nan|_out compilation on older Linux#3272
Closed
Fix portable is[inf|nan|_out compilation on older Linux#3272
Conversation
By wrapping a potentially non-compliant `isinf`/`isnan` implementations into a lambda with a defined return type Compiler should be able to optimize it out into direct function call, see https://godbolt.org/z/bqYGd47Mx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3272
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8a7986c with merge base b7b40ac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
approved these changes
Apr 24, 2024
manuelcandales
approved these changes
Apr 24, 2024
Contributor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up after #3262 that didn't actually solved the problem..
By wrapping a potentially non-compliant
isinf/isnanimplementations into a lambda with a defined return typeCompiler should be able to optimize it out into direct function call, see https://godbolt.org/z/bqYGd47Mx