Tester: rename inputs to example_inputs#3800
Tester: rename inputs to example_inputs#3800oscarandersson8218 wants to merge 1 commit intopytorch:mainfrom
Conversation
Rename inputs to example_inputs to differentiate between what's used as test data and what's used as example/calibration data. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: Ibe6e65fd3f6ec14a8f27fe2270595a3835b1e038
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3800
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1054c5e with merge base 13ba3a7 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sorry I still don't understand the motivation. But if it is just a rename then sure. |
@digantdesai Yes, it's just a renaming. Prior to #2442, run_method() would use Tester.inputs if no inputs were provided to the function, but that's no longer the case. Tester.inputs is only used as example/calibration data (unless I'm missing something). |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 8c70a50. |
Rename inputs to example_inputs to differentiate between what's used as test data and what's used as example/calibration data.
Change-Id: Ibe6e65fd3f6ec14a8f27fe2270595a3835b1e038