Skip to content

[ET-VK] Move ParamsBuffer and StorageBuffer to standalone files #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junpi3 wants to merge 2 commits into from
Closed

[ET-VK] Move ParamsBuffer and StorageBuffer to standalone files #4120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d897ac3
[ET-VK] Move `ParamsBuffer` and `StorageBuffer` to standalone files
Jul 2, 2024
73ab79b
Update on "[ET-VK] Move `ParamsBuffer` and `StorageBuffer` to standal…
Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update on "[ET-VK] Move ParamsBuffer and StorageBuffer to standal… 
…one files"

Includes the renaming of `UniformParamsBuffer` to `ParamsBuffer` for brevity.

These objects aren't tightly coupled to `Context` and hence they are better placed in standalone files.

Differential Revision: [D59281543](https://our.internmc.facebook.com/intern/diff/D59281543/)

[ghstack-poisoned]
  • Loading branch information
Jorge Pineda committed Jul 2, 2024
commit 73ab79b9958a11243abd7ea039f7c3083c64a54a
1 change: 0 additions & 1 deletion backends/vulkan/runtime/api/ParamsBuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include <executorch/backends/vulkan/runtime/api/ParamsBuffer.h>

#include <cstdint>
#include <cstring>

namespace vkcompute {
Expand Down