Clean up Outdated Args from Llama Export Script#5762
Closed
YifanShenSZ wants to merge 1 commit intopytorch:mainfrom
Closed
Clean up Outdated Args from Llama Export Script#5762YifanShenSZ wants to merge 1 commit intopytorch:mainfrom
YifanShenSZ wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5762
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0b1e89c with merge base 905b88c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
No need to cherry pick this PR, since it won't affect any beta release functionality |
Contributor
|
@YifanShenSZ Closing this PR since it has become stale. If you feel this is still relevant or you still face the issue discussed, feel free to re-open this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 coreml-specific args were introduced to llama export script
--coreml-enable-state--coreml-preserve-sdpaSince users would want to target iOS version rather than tune optimizations, #5319 introduced
--coreml-ios 18. However, #5319 forgot to remove the outdated--coreml-enable-stateand--coreml-preserve-sdpa