[aosp] Fix internal build error by adding static#6662
[aosp] Fix internal build error by adding static#6662davidlin54 wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6662
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit e8671c1 with merge base cd565b5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@davidlin54 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@davidlin54 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @davidlin54! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@kirklandsign how shall we proceed with this? |
|
No longer needed. Fixed already as https://github.com/pytorch/executorch/blob/main/extension/data_loader/file_descriptor_data_loader.cpp |
Summary
#6611 causes internal builds to break due to missing static qualifier. adding it here
Test plan
same test plan as #6611