[ET-VK] Removing unnecessary and redundant members from VulkanBuffer and ParamsBuffer.#7144
Merged
facebook-github-bot merged 5 commits intogh/trivedivivek/16/basefrom Dec 6, 2024
Merged
Conversation
…and ParamsBuffer. This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/) [ghstack-poisoned]
pytorch-bot
Bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7144
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 22d23d9 with merge base 63238ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Dec 2, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66557456 |
…lkanBuffer and ParamsBuffer." This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Dec 2, 2024
…and ParamsBuffer. Pull Request resolved: #7144 This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. ghstack-source-id: 256100389 @exported-using-ghexport Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66557456 |
Abhi-hpp
approved these changes
Dec 3, 2024
junpi3
approved these changes
Dec 3, 2024
…lkanBuffer and ParamsBuffer." This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66557456 |
…lkanBuffer and ParamsBuffer." This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66557456 |
…lkanBuffer and ParamsBuffer." This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66557456 |
This was referenced Dec 6, 2024
Merged
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
guangy10
pushed a commit
that referenced
this pull request
Dec 6, 2024
…and ParamsBuffer. (#7226) Pull Request resolved: #7144 This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer. ghstack-source-id: 256911526 @exported-using-ghexport Differential Revision: [D66557456](https://our.internmc.facebook.com/intern/diff/D66557456/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff removes unnecessary and redundant members from VulkanBuffer and ParamsBuffer.
Differential Revision: D66557456