Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
83b59e6
[ET-VK] Replace Uniform buffers with push constants for binary op
trviv Dec 6, 2024
c91bd80
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 6, 2024
ecee457
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 6, 2024
2c76113
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 9, 2024
e6ff460
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 9, 2024
6104ce0
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 10, 2024
c5e22de
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 11, 2024
2ce975a
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 11, 2024
7767dbc
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 12, 2024
dec9a06
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 12, 2024
f1d1c4b
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 12, 2024
8b4e434
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 12, 2024
422aa90
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 16, 2024
b479914
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 17, 2024
3efa1e6
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 17, 2024
1b026ff
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 17, 2024
70e2d1a
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 17, 2024
4479bc9
Update on "[ET-VK] Replace Uniform buffers with push constants for b…
trviv Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update on "[ET-VK] Replace Uniform buffers with push constants for bi…
…nary op"

This diff replaces uniform buffers with push constants for binary op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: [D66853542](https://our.internmc.facebook.com/intern/diff/D66853542/)

[ghstack-poisoned]
  • Loading branch information
trviv committed Dec 10, 2024
commit 6104ce0ef636d8c1c3c42ef767674976e6505dd0
4 changes: 1 addition & 3 deletions backends/vulkan/test/vulkan_compute_api_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1601,9 +1601,7 @@ TEST(VulkanComputeGraphTest, test_simple_shared_objects_with_resize) {
auto addFn = VK_GET_OP_FN("aten.add.Tensor");
addFn(graph, {a.value, b.value, kDummyValueRef, c});

// +2: alpha UBO, broadcast UBO for arithmetic shader
// +1: t.sizes_ubo() for arithmetic shader output c
expected_vma_allocation_count += 3;
expected_vma_allocation_count += 0;
EXPECT_EQ(get_vma_allocation_count(), expected_vma_allocation_count);

IOValueRef d = graph.add_input_tensor(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.