[ET-VK] Adding function to set push constants in Command buffer.#7250
Merged
kirklandsign merged 1 commit intomainfrom Dec 10, 2024
Merged
[ET-VK] Adding function to set push constants in Command buffer.#7250kirklandsign merged 1 commit intomainfrom
kirklandsign merged 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7250
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 85c4a4e with merge base 28ad3f2 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
force-pushed
the
gh/trivedivivek/19/orig
branch
from
22f3d39 to
756b8ab
Compare
kirklandsign
approved these changes
Dec 10, 2024
Pull Request resolved: #7221 This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. ghstack-source-id: 257227241 @exported-using-ghexport Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/)
kirklandsign
force-pushed
the
gh/trivedivivek/20/orig
branch
from
7410887 to
85c4a4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7221
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/20/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/20/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/19/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/20/orig
@diff-train-skip-merge