Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
9abe1ea
Add more e2e models to OSS CI
huydhn Aug 18, 2023
20098af
Set PYTHON_EXECUTABLE to python
huydhn Aug 18, 2023
1185029
Run cmake model tests on MacOS
huydhn Aug 18, 2023
3f18ec2
Set default python
huydhn Aug 18, 2023
335cc14
Check for unbound variable
huydhn Aug 18, 2023
de98573
Try to add matrix support
huydhn Aug 18, 2023
c617850
Syntax error
huydhn Aug 18, 2023
37d3e57
JSON input
huydhn Aug 18, 2023
70a3729
The YAML looks valid
huydhn Aug 18, 2023
7db30c3
Debug invalid YAML
huydhn Aug 18, 2023
8d12f7d
Debug passing model name
huydhn Aug 18, 2023
64ec005
Debug passing model name
huydhn Aug 18, 2023
5bf8102
Try to reuse binary-matrix param
huydhn Aug 18, 2023
0736a6b
Debug JSON format
huydhn Aug 18, 2023
dade4e9
Use double quote
huydhn Aug 18, 2023
df33e70
Silly me, the example is right there
huydhn Aug 18, 2023
89659e2
Use a fixed list of models (v1)
huydhn Aug 18, 2023
9811290
No need to set binary-matrix
huydhn Aug 18, 2023
a04a539
Remove linear
huydhn Aug 18, 2023
7bceb78
Install torchvision
huydhn Aug 18, 2023
cf4e4d8
Dynamically gather the list of test models
huydhn Aug 18, 2023
740e40f
Fix workflow syntax
huydhn Aug 18, 2023
4caadd4
Fix workflow syntax
huydhn Aug 18, 2023
9368d2f
Run as a linux job
huydhn Aug 18, 2023
08fa8e4
Install executorch
huydhn Aug 18, 2023
a843d6d
Need to use regular job
huydhn Aug 18, 2023
6f43a30
Install executorch
huydhn Aug 18, 2023
66c3a78
Debug GitHub output
huydhn Aug 18, 2023
791f92d
Correctly set the job output
huydhn Aug 18, 2023
b6b6ff5
Merge branch 'main' into add-more-e2d-models-T160762924
huydhn Aug 18, 2023
82089d6
Fix typo
huydhn Aug 18, 2023
3600da2
Install torchaudio
huydhn Aug 18, 2023
f27b84e
Remove fetch-depth 0
huydhn Aug 18, 2023
f2fa004
Add torchaudio to Docker image
huydhn Aug 18, 2023
b5667d5
Fix internal linter comments
huydhn Aug 18, 2023
dd79992
Put nightly suffix in a separate file to be shared by torch/vision/audio
huydhn Aug 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Debug GitHub output
  • Loading branch information
huydhn committed Aug 18, 2023
commit 66c3a78de59de523c29885e527c3de2574fd5c55
2 changes: 2 additions & 0 deletions .ci/scripts/gather_test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ def set_output(name: str, val: Any) -> None:
"""
Set the GitHb output so that it can be accessed by other jobs
"""
print(f"Setting {val} to GitHub output")

if os.getenv("GITHUB_OUTPUT"):
with open(str(os.getenv("GITHUB_OUTPUT")), "a") as env:
print(f"{name}={val}", file=env)
Expand Down
166 changes: 83 additions & 83 deletions .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,86 +57,86 @@ jobs:
# Test custom ops
bash examples/custom_ops/test_custom_ops.sh buck2

buck-build-test-macos:
name: buck-build-test-macos
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
strategy:
matrix:
include:
- model: linear
- model: mv2
fail-fast: false
with:
runner: macos-m1-12
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
script: |
WORKSPACE=$(pwd)

pushd "${WORKSPACE}/pytorch/executorch"
# Setup MacOS dependencies as there is no Docker support on MacOS atm
bash .ci/scripts/setup-macos.sh

# The name of model we are going to test
MODEL_NAME=${{ matrix.model }}
# Build and test Executorch
PYTHON_EXECUTABLE=python bash .ci/scripts/test.sh "${MODEL_NAME}"
# Test custom ops
PYTHON_EXECUTABLE=python bash examples/custom_ops/test_custom_ops.sh buck2
popd

cmake-build-test-linux:
name: cmake-build-test-linux
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
strategy:
matrix:
include:
- model: linear
- model: mv2
fail-fast: false
with:
runner: linux.2xlarge
docker-image: executorch-ubuntu-22.04-clang12
fetch-depth: 0
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
script: |
PYTHON_VERSION=3.10
# TODO: Figure out why /opt/conda/envs/py_$PYTHON_VERSION/bin is not in the path
# here, as it's there in the container
export PATH="/opt/conda/envs/py_${PYTHON_VERSION}/bin:${PATH}"

# The name of model we are going to test
MODEL_NAME=${{ matrix.model }}
# Build and test Executorch
bash .ci/scripts/test-cmake.sh "${MODEL_NAME}"
# Build and test custom ops
bash examples/custom_ops/test_custom_ops.sh cmake

cmake-build-test-macos:
name: cmake-build-test-macos
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
strategy:
matrix:
include:
- model: linear
- model: mv2
fail-fast: false
with:
runner: macos-m1-12
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
script: |
WORKSPACE=$(pwd)

pushd "${WORKSPACE}/pytorch/executorch"
# Setup MacOS dependencies as there is no Docker support on MacOS atm
bash .ci/scripts/setup-macos.sh

# The name of model we are going to test
MODEL_NAME=${{ matrix.model }}
# Build and test Executorch
PYTHON_EXECUTABLE=python bash .ci/scripts/test-cmake.sh "${MODEL_NAME}"
# Build and test custom ops
PYTHON_EXECUTABLE=python bash examples/custom_ops/test_custom_ops.sh cmake
popd
# buck-build-test-macos:
# name: buck-build-test-macos
# uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
# strategy:
# matrix:
# include:
# - model: linear
# - model: mv2
# fail-fast: false
# with:
# runner: macos-m1-12
# submodules: 'true'
# ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
# script: |
# WORKSPACE=$(pwd)
#
# pushd "${WORKSPACE}/pytorch/executorch"
# # Setup MacOS dependencies as there is no Docker support on MacOS atm
# bash .ci/scripts/setup-macos.sh
#
# # The name of model we are going to test
# MODEL_NAME=${{ matrix.model }}
# # Build and test Executorch
# PYTHON_EXECUTABLE=python bash .ci/scripts/test.sh "${MODEL_NAME}"
# # Test custom ops
# PYTHON_EXECUTABLE=python bash examples/custom_ops/test_custom_ops.sh buck2
# popd
#
# cmake-build-test-linux:
# name: cmake-build-test-linux
# uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
# strategy:
# matrix:
# include:
# - model: linear
# - model: mv2
# fail-fast: false
# with:
# runner: linux.2xlarge
# docker-image: executorch-ubuntu-22.04-clang12
# fetch-depth: 0
# submodules: 'true'
# ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
# script: |
# PYTHON_VERSION=3.10
# # TODO: Figure out why /opt/conda/envs/py_$PYTHON_VERSION/bin is not in the path
# # here, as it's there in the container
# export PATH="/opt/conda/envs/py_${PYTHON_VERSION}/bin:${PATH}"
#
# # The name of model we are going to test
# MODEL_NAME=${{ matrix.model }}
# # Build and test Executorch
# bash .ci/scripts/test-cmake.sh "${MODEL_NAME}"
# # Build and test custom ops
# bash examples/custom_ops/test_custom_ops.sh cmake
#
# cmake-build-test-macos:
# name: cmake-build-test-macos
# uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
# strategy:
# matrix:
# include:
# - model: linear
# - model: mv2
# fail-fast: false
# with:
# runner: macos-m1-12
# submodules: 'true'
# ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
# script: |
# WORKSPACE=$(pwd)
#
# pushd "${WORKSPACE}/pytorch/executorch"
# # Setup MacOS dependencies as there is no Docker support on MacOS atm
# bash .ci/scripts/setup-macos.sh
#
# # The name of model we are going to test
# MODEL_NAME=${{ matrix.model }}
# # Build and test Executorch
# PYTHON_EXECUTABLE=python bash .ci/scripts/test-cmake.sh "${MODEL_NAME}"
# # Build and test custom ops
# PYTHON_EXECUTABLE=python bash examples/custom_ops/test_custom_ops.sh cmake
# popd