Skip to content

portable arg{max,min}: optimize update check #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swolchok wants to merge 3 commits into from
Closed

portable arg{max,min}: optimize update check #8755

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9bd251
Update
swolchok Feb 27, 2025
da58a57
Update
swolchok Feb 27, 2025
85af042
Update
swolchok Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 
[ghstack-poisoned]
  • Loading branch information
@swolchok
swolchok committed Feb 27, 2025
commit da58a574e995aa1c8bfbae081ba30118e0396a89
4 changes: 2 additions & 2 deletions kernels/portable/cpu/op_argmin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ Tensor& argmin_out(
for (size_t out_ix = 0; out_ix < out.numel(); ++out_ix) {
std::tuple<CTYPE, long> acc = reduce_over_dim<CTYPE>(
[](CTYPE v, long ix, CTYPE acc_val, long acc_ix) {
// the below condition as written is equivalent to !isnan(accval) && (isnan(v) || v < acc_val).
// cases:
// the below condition as written is equivalent to !isnan(accval) &&
// (isnan(v) || v < acc_val). cases:
// - if neither acc_val nor v is NaN, !(v >= acc_val) is
// trivially equivalent to v < acc_val.
// - if acc_val is NaN, the whole thing is trivially false.
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.