Fix FashionMNIST loading MNIST - #640
Merged
Merged
Conversation
fmassa
requested changes
Oct 26, 2018
fmassa
left a comment
fmassa
left a comment
Member
There was a problem hiding this comment.
This is awesome, thanks a lot for the PR!
There is only a small lint issue, but after that this is good to merge!
| 'train-labels-idx1-ubyte.gz': '25c81989df183df01b3e8a0aad5dffbe', | ||
| } | ||
|
|
||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Before this would lead FashionMNIST to contain mnist data: ``` MNIST(root, download=True) FashionMNIST(root, download=True) ``` As MNIST and FashionMNIST are the same classes, the processed outputs actual ended up to be the same files. This commit now stores them at different files and also stores the class name when saving them. I also added md5 sums.
ls1xt
force-pushed
the
fix-fashion-mnist
branch
from
October 26, 2018 17:47
1e23d10 to
436cb4d
Compare
Contributor
Author
|
I fixed the lint problem. Thank you! |
Contributor
|
thanks @berleon |
Contributor
|
Are you kidding? I've already fixed this problem in #601 ... omg. |
Member
|
There seems to be indeed two PRs that conflicted with each other. I'm reverting this one, sorry for the trouble! |
fmassa
added a commit
that referenced
this pull request
Oct 30, 2018
Member
|
@berleon there were some nice functionalities from your PR that were reverted, like the tests and the md5 checks. |
rajveerb
pushed a commit
to rajveerb/vision
that referenced
this pull request
Nov 30, 2023
* Update README.md * Update README.md Add Data download info * [GPT3] Clean up README so it is easier for others to follow instructions --------- Co-authored-by: Shriya Palsamudram <spalsamudram@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this would lead FashionMNIST to contain mnist data:
As FashionMNIST inherits almost everything from MNIST, the processed
outputs actual ended up to be the same files. This commit now
stores them at different files and also stores the class name when
saving them. I also added md5 sums.