add pyproject.toml#4
Merged
Merged
Conversation
Member
|
This is also addressed in #3 but it might make sense to merge it as a standalone PR. |
Member
|
I'm merging this into master, as it looks like the scikit-build transition may take a bit of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this seems to be the new line_profiler repo. Pip installing it from source will fail, if cython is not installed:
This problem can be solved by marking cython as build dependency using a
pyproject.tomlfile (PEP 518).Also see: https://stackoverflow.com/questions/18023546/marking-cython-as-a-build-dependency