fix: fetch http(s) type: file vector sources, reject other schemes

[tellet-q]

Allow https:// url only, reject s3://.

All Submissions:

• Contributions should target the dev branch. Did you create your branch from dev?
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[Copilot]

Pull request overview

This PR makes source: { type: file } vector sources safer and more flexible by supporting remote HTTP(S) .fbin files via a download+cache path, rejecting non-HTTP(S) URL schemes during config validation, and eliminating panics when opening vector files.

Changes:

• Make FBinReader::new fallible and propagate errors instead of panicking on open/mmap failures.
• Add ensure_local_file to download/cache HTTP(S) type: file vector sources and update generators to use it.
• Centralize file-source path validation (including scheme rejection) and add tests/docs for remote file sources.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/upload.rs	Propagates FBinReader open failures instead of panicking.
src/generators/queries.rs	Resolves VectorSource::File paths via ensure_local_file before reading .fbin.
src/generators/config.rs	Uses ensure_local_file for config-driven uploads and adds a test for remote .fbin vectors.
src/fbin_reader.rs	Converts .fbin reader construction to Result and adds basic header-length validation.
src/dataset/mod.rs	Re-exports download helpers and adds a small HTTP test server module for download-path tests.
src/dataset/download.rs	Implements remote-file detection, download-to-cache for file sources, and related tests.
src/config/search.rs	Switches to shared validate_file_source_path for search-config validation.
src/config/schema.rs	Updates schema docs to reflect HTTP(S) file-source support (and removal of s3://).
src/config/mod.rs	Adds validate_file_source_path and tests for scheme acceptance/rejection.
examples/upload-config.yaml	Documents HTTP(S) URL support and caching behavior for file vector sources.

Comments suppressed due to low confidence (1)

src/fbin_reader.rs:5

• size_of is used in this file but not imported, which will fail to compile. Import it alongside transmute (or fully-qualify the calls).

use std::fs::OpenOptions;
use std::mem::transmute;
use std::path::Path;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.