Skip to content

Geo polygons support#325

Merged
generall merged 8 commits intodevfrom
geo-polygons
Oct 6, 2023
Merged

Geo polygons support#325
generall merged 8 commits intodevfrom
geo-polygons

Conversation

@agourlay
Copy link
Member

@agourlay agourlay commented Oct 5, 2023

This PR represents the work of #272 which I packaged with the latest client changes.


In Qdrant #2315, we implement GeoPolygon Filter. This change introduces the local mode of GeoPolygon. It includes:

  1. add a new library sharply we will rely on for geometry computation
  2. add check_geo_polygon_ function and tests to check polygon intersection
  3. add geo filter congruence test to test consistency between local mode and remote mode

@agourlay agourlay marked this pull request as ready for review October 5, 2023 14:47
@generall
Copy link
Member

generall commented Oct 6, 2023

FYI @agourlay @zzzz-vincent , I had to remove shapely from dependencies. It is tricky to install on python 3.12 as it requires building some kind of c++ dependency, which might not present in the system. Pure python might not be as fast, but I am concerned by introducing potential additional problems into client non-optional dependency for local mode

@generall generall merged commit 93edff8 into dev Oct 6, 2023
generall added a commit that referenced this pull request Oct 6, 2023
* regenerate client

* regen grpc client

* document build process

* work from Zein in #272

* update rest client with optional field

* code refactor and better naming

* remove shapely as a dependency

* fix typing

---------

Co-authored-by: zzzz-vincent <wenzishen.vincent@hotmail.com>
Co-authored-by: generall <andrey@vasnetsov.com>
@generall generall deleted the geo-polygons branch May 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants