Skip to content

RGB Matrix Caps Lock and Layer indicator example#13367

Merged
drashna merged 8 commits intoqmk:masterfrom
filterpaper:rgbmatrix-indicator-examples
Jul 3, 2021
Merged

RGB Matrix Caps Lock and Layer indicator example#13367
drashna merged 8 commits intoqmk:masterfrom
filterpaper:rgbmatrix-indicator-examples

Conversation

@filterpaper
Copy link
Member

@filterpaper filterpaper commented Jun 28, 2021

Description

Provide some examples on using RGB Matrix as indicators, a frequently asked question on the QMK discord.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 29, 2021 01:30
Co-authored-by: Ryan <fauxpark@gmail.com>
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer that both of these use the "advanced" function examples, as they're broken up into chunks for faster rendering

@filterpaper
Copy link
Member Author

Would prefer that both of these use the "advanced" function examples, as they're broken up into chunks for faster rendering

I've updated the function example as advised.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be better, given how the functions work, and what you're trying to do.

filterpaper and others added 2 commits July 2, 2021 08:16
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@drashna drashna merged commit fdf71f1 into qmk:master Jul 3, 2021
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
@filterpaper filterpaper deleted the rgbmatrix-indicator-examples branch July 23, 2021 01:35
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants