Skip to content

Fix matrix for Tsangan#7159

Merged
noroadsleft merged 1 commit intoqmk:masterfrom
yanfali:yanfali-an-c-tsangan-fix
Oct 28, 2019
Merged

Fix matrix for Tsangan#7159
noroadsleft merged 1 commit intoqmk:masterfrom
yanfali:yanfali-an-c-tsangan-fix

Conversation

@yanfali
Copy link
Contributor

@yanfali yanfali commented Oct 26, 2019

  • 1st mod after space bar was wrong position

The key configured for Tsangan was a dead key that was switch to the left of the correct position for this layout.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

 - 1st mod after space bar was wrong position
@yanfali
Copy link
Contributor Author

yanfali commented Oct 26, 2019

@awkannan found an issue with the Tsangan matrix on the AN-C. This look ok to you?

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft
Copy link
Member

Thanks!

@noroadsleft noroadsleft merged commit a096453 into qmk:master Oct 28, 2019
@yanfali yanfali deleted the yanfali-an-c-tsangan-fix branch October 29, 2019 01:41
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
- 1st mod after space bar was wrong position
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
- 1st mod after space bar was wrong position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants