ARM split - Add uart half duplex transport support by zvecr · Pull Request #7987 · qmk/qmk_firmware

zvecr · 2020-01-23T15:20:57Z

Current Issue

Transport does not exist

TL;DR

This PR adds a hardware backed transport mechanism which might work on I2C based boards.

Description

Provides a method of transport that does not require a patch or upgrade to ChibiOS. Hardware backed, this avoids some of the locking conflicts from within #7072. The downside is that it requires pullups on the TX line, and using pins which share I2C/USART, rather than the bitbang serial which can run on whatever. A good proportion of pro micro splits can run I2C, so this is potentially already covered for CTPC.

Scan rate goes over 2k with higher speed options so more than enough to keep up with current AVR boards.

TODO

non f303 testing
Unpick makefile changes - Update split serial code to use driver pattern #7990
Remove keyboard changes from testing
Add docs

Testing Notes

Chip	Status	Notes
f072	?	compiles but not enough hardware to test
f103	✔️	with `AFIO->MAPR \|= AFIO_MAPR_USART1_REMAP`
f303	✔️
f401/f411	✔️

Types of Changes

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna · 2020-01-25T20:45:58Z

Looks good, though, the default keymaps for the levinson is compiling too large.

zvecr · 2020-01-25T21:53:47Z

Going to rip those extra files out once I rebase for #7995. This PR should have no impact on existing board, unless you basically add those changes back locally, but while im fixing things up I thought i would leave them there.

ARM split - Add uart half duplex transport support

drivers/arm/serial_usart.c

docs/serial_driver.md

drivers/arm/serial_usart.c

drivers/arm/serial.h

drivers/arm/serial_usart.c

tzarc · 2020-02-21T09:19:06Z

I guess half of the requested changes should probably be split out into a differently-focused PR, specifically that works for both the AVR and ARM implementations. Split transport uses the SSTD_t stuff, so probably best left out of scope for this PR. Will go cancel the requested changes accordingly.

drivers/arm/serial_usart.c

drashna · 2020-04-28T06:52:49Z

docs/serial_driver.md

+
+Configure the hardware via your config.h:
+```c
+#define SOFT_SERIAL_PIN B6  // USART TX pin


Does this default to B6? If you're using CTPC, this may not be B6.

Edit: This doesn't appear to be set to a default. But it may be worth mentioning if CPTC is enabled, then you want to use the AVR pin name.

No default, it was just an example based on D0 above, but pins change depending on which stm chip you target so couldnt list them all.

drivers/chibios/serial_usart.c

docs/serial_driver.md

Co-authored-by: Nick Brassel <nick@tzarc.org>

* ARM split - Add uart half duplex transport support * Fix for f103 * initial full duplex pass * partially remove full duplex * Correct speeds within driver docs Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Nick Brassel <nick@tzarc.org> format code according to conventions [skip ci]

* ARM split - Add uart half duplex transport support * Fix for f103 * initial full duplex pass * partially remove full duplex * Correct speeds within driver docs Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Nick Brassel <nick@tzarc.org>

* ARM split - Add uart half duplex transport support * Fix for f103 * initial full duplex pass * partially remove full duplex * Correct speeds within driver docs Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Nick Brassel <nick@tzarc.org> format code according to conventions [skip ci]

* ARM split - Add uart half duplex transport support * Fix for f103 * initial full duplex pass * partially remove full duplex * Correct speeds within driver docs Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Nick Brassel <nick@tzarc.org>

zvecr added the core label Jan 23, 2020

zvecr requested a review from a team January 23, 2020 15:20

zvecr mentioned this pull request Jan 24, 2020

Update split serial code to use driver pattern #7990

Merged

13 tasks

zvecr force-pushed the feature/arm_split_uart_half branch from e5cdfc2 to 1c43421 Compare January 24, 2020 13:55

zvecr mentioned this pull request Jan 24, 2020

Remove compilation of i2c for arm split #7995

Merged

13 tasks

zvecr force-pushed the feature/arm_split_uart_half branch from 7e90818 to 2fd7b9c Compare January 27, 2020 22:48

zvecr marked this pull request as ready for review February 2, 2020 03:31

drashna previously approved these changes Feb 2, 2020

View reviewed changes

drashna requested a review from a team February 2, 2020 19:52

zvecr added a commit that referenced this pull request Feb 4, 2020

Merge pull request #7987 from zvecr/feature/arm_split_uart_half

731b6cb

ARM split - Add uart half duplex transport support

tzarc requested changes Feb 21, 2020

View reviewed changes

tzarc requested a review from a team February 21, 2020 09:05

zvecr force-pushed the feature/arm_split_uart_half branch from 833d03b to 03c36fb Compare February 21, 2020 21:38

tzarc previously approved these changes Feb 24, 2020

View reviewed changes

tzarc requested a review from a team February 24, 2020 01:39

zvecr force-pushed the feature/arm_split_uart_half branch 2 times, most recently from 2edfc8c to 979a48d Compare February 24, 2020 02:29

zvecr dismissed stale reviews from tzarc and drashna via 2fb9bae February 28, 2020 23:14

zvecr force-pushed the feature/arm_split_uart_half branch from 979a48d to 2fb9bae Compare February 28, 2020 23:14

zvecr changed the base branch from master to future February 28, 2020 23:14

noroadsleft force-pushed the future branch from edc2f8b to b2b46fb Compare February 29, 2020 20:40

zvecr changed the base branch from future to master March 1, 2020 03:01

zvecr force-pushed the feature/arm_split_uart_half branch 3 times, most recently from d288937 to ee33ac1 Compare March 7, 2020 02:56

tzarc reviewed Mar 8, 2020

View reviewed changes

drivers/arm/serial_usart.c Outdated Show resolved Hide resolved

ARM split - Add uart half duplex transport support

8e90f4c

zvecr force-pushed the feature/arm_split_uart_half branch from cc1e7a7 to 8e90f4c Compare April 7, 2020 03:03

Fix for f103

1c4f02a

drashna reviewed Apr 28, 2020

View reviewed changes

zvecr added 2 commits May 10, 2020 21:57

initial full duplex pass

42452d1

partially remove full duplex

bb54a77

tzarc reviewed May 18, 2020

View reviewed changes

drivers/chibios/serial_usart.c Show resolved Hide resolved

drashna approved these changes May 18, 2020

View reviewed changes

drashna requested a review from a team May 18, 2020 09:59

tzarc requested changes May 18, 2020

View reviewed changes

docs/serial_driver.md Outdated Show resolved Hide resolved

Correct speeds within driver docs

66e04e5

Co-authored-by: Nick Brassel <nick@tzarc.org>

tzarc approved these changes May 18, 2020

View reviewed changes

zvecr merged commit 6515098 into qmk:master May 21, 2020

zvecr mentioned this pull request May 21, 2020

Update ARM split keyboard docs #9160

Merged

13 tasks

zvecr deleted the feature/arm_split_uart_half branch May 21, 2020 20:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ARM split - Add uart half duplex transport support#7987

ARM split - Add uart half duplex transport support#7987
zvecr merged 5 commits intoqmk:masterfrom
zvecr:feature/arm_split_uart_half

zvecr commented Jan 23, 2020 •

edited

Loading

Uh oh!

drashna commented Jan 25, 2020

Uh oh!

zvecr commented Jan 25, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzarc commented Feb 21, 2020

Uh oh!

Uh oh!

drashna Apr 28, 2020 •

edited

Loading

Uh oh!

zvecr May 10, 2020

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zvecr commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Issue

TL;DR

Description

Testing Notes

Types of Changes

Checklist

Uh oh!

drashna commented Jan 25, 2020

Uh oh!

zvecr commented Jan 25, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzarc commented Feb 21, 2020

Uh oh!

Uh oh!

drashna Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zvecr May 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zvecr commented Jan 23, 2020 •

edited

Loading

drashna Apr 28, 2020 •

edited

Loading