qmlpropdef: support list property types - #34
Merged
Merged
Conversation
ChALkeR
force-pushed
the
list-typed-props
branch
from
December 26, 2016 22:53
16404ac to
c48675f
Compare
ChALkeR
force-pushed
the
list-typed-props
branch
from
December 26, 2016 22:54
c48675f to
4fbfd52
Compare
Member
Author
|
Going to merge as-is (without additional type information). I extracted the type information question to #35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #33
Note that
subtypeis not exported to the result yet, hence labeling as «work in progress»./cc @akreuzkamp, any opinion on how this should be presented in the current output format?
Long-term, I would prefer to migrate from arrays to objects for such things (think ESTree).