fix Docker and Bazel CIs#628
Merged
Merged
Conversation
NoureldinYosri
changed the title
95-martin-orion
approved these changes
Oct 18, 2023
Collaborator
95-martin-orion
left a comment
95-martin-orion
left a comment
There was a problem hiding this comment.
All checks are passing. Thank your @NoureldinYosri for stepping in to resolve these issues!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #624
the docker CI failes due to a mismatch between system packages scientific libraries (e.g. numpy) installed by
python3-pybind11and those required by Cirq. Fix by allowing Cirq to override those packages' versions. This is the same as we had before with the--forceflag which doesn't seem to work anymore, instead I'm using `a virtualenvfixes #625
these were broken due to an update to the LLVM library which broke the compilation step https://bugs.llvm.org/show_bug.cgi?id=27310. Fix is to upgrade libc-bin.