Fix CI actions on GitHub#672
Merged
Merged
Conversation
Recent GHA runner images require docker-compose v2. Ref: actions/runner-images#9557
That version is possibly too old. Wheels for newer Python versions appear to build successfully.
It is nearing its end-of-life.
download-artifact@v4 requires some changes per https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
…lvm" This reverts commit 19b0b12.
This reverts commit 8d61570.
This reverts commit 2b9f1e0.
Handle multiple uploads per https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
95-martin-orion
approved these changes
Sep 13, 2024
Collaborator
95-martin-orion
left a comment
95-martin-orion
left a comment
There was a problem hiding this comment.
All checks passing - LGTM. Thanks for digging into this!
There are a few in-flight PRs that should be revisited now that they're unblocked by this.
Per GHA annotations all brew libraries are already installed.
This reverts commit f0bddf1.
Run test-mem job on ubuntu-20 for it for some reason fails on ubuntu-22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
job on ubuntu-20 for it for some reason fails on ubuntu-22
actions/checkout@v4, actions/setup-python@v5, download-artifact@v4, upload-artifact@v4
https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
to the macos version