Extended and ordered list of headers#4
Open
m42e wants to merge 2 commits into
Open
Conversation
Owner
|
Wow, |
Owner
There was a problem hiding this comment.
Did you mean R[C['duration', 'time_point']]]?
Author
There was a problem hiding this comment.
No, as their full declaration is std::chrono::time_point and std::chrono::duration
Owner
|
Could you split adding new stuff and sorting lines into two commits? This way it will be much clear to see what is actually changed. |
Author
|
Is one pull request ok, when it contains two commits? |
Owner
|
Yes. One pull request with multiple commits is okay. |
m42e
force-pushed
the
update_includes
branch
from
653550a to
77d882f
Compare
Author
|
Here it is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordered the list alphabetically and added some more headers