-
Notifications
You must be signed in to change notification settings - Fork 394
Add page-numbering to schema
#13516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add page-numbering to schema
#13516
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Was this added in v1.8? It would mean we need to backport the schema change to v1.8 too so that it works in auto-completion and YAML validation |
|
I think 1.7 😬 |
|
backporting to 1.8 seems needed then. Too late for 1.7 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the page-numbering option to the schema for Typst format documents. This option allows users to control page numbering style (e.g., 1 for Arabic numerals, i for Roman numerals) or disable it entirely with false.
- Adds new
page-numberingschema option accepting either a boolean or string value - Restricts the option to Typst format only via format tags
- Includes documentation with reference to Typst's numbering documentation
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/resources/schema/document-numbering.yml |
Defines the new page-numbering option schema with boolean/string types, Typst format tag, and descriptive documentation |
src/resources/editor/tools/yaml/yaml-intelligence-resources.json |
Generated JSON resource file reflecting the new schema definition for YAML intelligence |
src/resources/editor/tools/yaml/web-worker.js |
Generated web worker JavaScript including the new schema for editor tooling |
src/resources/editor/tools/vs-code.mjs |
Generated VS Code extension module with the new schema definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # src/resources/editor/tools/vs-code.mjs # src/resources/editor/tools/yaml/all-schema-definitions.json # src/resources/editor/tools/yaml/web-worker.js # src/resources/editor/tools/yaml/yaml-intelligence-resources.json
|
Sorry, I forgot to merge this. I fixed the conflict and the typo. I'll open the backport too |
Description
Add
page-numberingto the schema forformat: typstRequired for #13515