fix: make sure all whiteout files are processed#1887
Open
knrc wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kevin Conner <kev.conner@gmail.com>
knrc
force-pushed
the
fix_layer_mapping_files
branch
from
2ea420b to
b3fe47d
Compare
Contributor
|
f45f117 for reference |
Author
Yeah, using a slice was my original approach from a year or so back. I changed the implementation when I looked at the way the tests were being written, assuming the intent was to coalesce the entries. Any idea why that's not in main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the mapping for
IndexReportfiles within a layer. The previous mapping was for one file per layer, with one consequence being the inability to handle more than one whiteout file per layer.