web console/refactor jquery modules - #20
Merged
Merged
Conversation
they're now used directly in Result
no longer needed, as grid and quickVis are initiated in Result
argshook
commented
Jul 18, 2022
insmac
approved these changes
Jul 22, 2022
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
* remove unused constants * refactor globals.js * move docsearch css import to index.tsx * make quick-vis as module * make grid as module * add @types/jquery * use grid and quickVis modules in Result * remove quickVis and grid from console/index.js they're now used directly in Result * refactor globals * remove console-controller no longer needed, as grid and quickVis are initiated in Result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a cleanup and refactor with the aim to make
grid.jsandquick-vis.jseasier to reuse in React code