Skip to content

add test for query run when cursor position is next to ending semicolon #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argshook merged 2 commits into from
May 27, 2022
Merged

add test for query run when cursor position is next to ending semicolon #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e27c68c
add test for query run when cursor position is next to ending semicolon
argshook May 27, 2022
ec08c16
one more case without second semicolon
argshook May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 40 additions & 4 deletions packages/browser-tests/cypress/integration/console/editor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// <reference types="cypress" />

const baseUrl = "http://localhost:9999"
const baseUrl = "http://localhost:9999";

describe("appendQuery", () => {
const consoleConfiguration = {
Expand Down Expand Up @@ -128,7 +128,11 @@ describe("&query URL param", () => {

it("should append and select multiline query", () => {
cy.visit(baseUrl);
cy.runQuery(`select x\nfrom long_sequence(1);\n\n-- a\n-- b\n-- c\n${'{upArrow}'.repeat(5)}`);
cy.runQuery(
`select x\nfrom long_sequence(1);\n\n-- a\n-- b\n-- c\n${"{upArrow}".repeat(
5
)}`
);
const query = encodeURIComponent("select x+1\nfrom\nlong_sequence(1);");
cy.visit(`${baseUrl}?query=${query}&executeQuery=true`);
cy.getGridRow(0).should("contain", "2").snapshot();
Expand All @@ -148,8 +152,7 @@ describe("autocomplete", () => {
it("should work when tables list is empty", () => {
cy.visit(baseUrl);
cy.typeQuery("select * from tel");
cy.getAutocomplete().should("not.contain", "telemetry");
cy.getAutocomplete().should("contain", "TABLE");
cy.getAutocomplete().should("not.be.visible");
cy.clearEditor();
cy.runQuery('create table "my_secrets" ("secret" string)');
cy.typeQuery("select * from my_");
Expand Down Expand Up @@ -194,3 +197,36 @@ describe("errors", () => {
cy.getErrorMarker().snapshot();
});
});

describe("running query with F9", () => {
beforeEach(() => {
Cypress.on("uncaught:exception", (err) => {
// this error can be safely ignored
if (err.message.includes("ResizeObserver loop limit exceeded")) {
return false;
}
});
});

it("should execute correct query, when text cursor is on query which has no semicolon", () => {
cy.visit(baseUrl);
cy.typeQuery("select * from long_sequence(1)").F9();
cy.getGridRow(0).should("contain", "1");
cy.clearEditor();
cy.typeQuery(`select * from long_sequence(2);{leftArrow}`).F9();
cy.wait(100).getGridRow(1).should("contain", "2");
});

it("should execute correct query, when multiple queries exist", () => {
cy.visit(baseUrl);
cy.typeQuery(
"long_sequence(10) where x = 3;\n\nlong_sequence(5) limit 2;{upArrow}{upArrow}{end}{leftArrow}"
).F9();
cy.getGridRow(0).should("contain", "3");
cy.clearEditor();
cy.typeQuery(
"long_sequence(10) where x = 3;\n\nlong_sequence(5) limit 2{upArrow}{upArrow}{end}{leftArrow}"
).F9();
cy.getGridRow(0).should("contain", "3");
});
});
14 changes: 7 additions & 7 deletions packages/browser-tests/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,7 @@ Cypress.Commands.add("getGridViewport", () => cy.get(".qg-viewport"));
Cypress.Commands.add("getGridRow", (n) => cy.get(".qg-r").eq(n));

Cypress.Commands.add("typeQuery", (query) =>
cy
.get(".monaco-editor")
.first()
.click()
.focused()
.type("{ctrl}a")
.type(`${query}`)
cy.get(".monaco-editor").first().click().focused().type("{ctrl}a").type(query)
);

Cypress.Commands.add("runQuery", (query) => {
Expand Down Expand Up @@ -43,3 +37,9 @@ Cypress.Commands.add("getAutocomplete", () =>
);

Cypress.Commands.add("getErrorMarker", () => cy.get(".squiggly-error"));

Cypress.Commands.add("F9", () =>
cy.getEditor().trigger("keydown", {
keyCode: 120,
})
);
Loading