refactor: remove the hidden custom proxy-URL step - #163
Merged
Conversation
The "Choose proxy URL" step was wired up but permanently disabled (SHOW_PROXY_URL_STEP=false), so it never rendered and never persisted anything. Remove it end to end — TUI, SetupApp wiring, and the persistence/consumption plumbing that only it used. - Delete the ProxyUrl component and its test. - SetupApp: drop the proxy-url phase, SHOW_PROXY_URL_STEP, POST_INSTALL, proxyChoice/pendingSurvivors state, handleProxyUrlConfirm, the auto-advance effect, and the ProxyUrl render. handleLoginDone / handleInstallDone now call runPostInstallSideEffects directly. - auth.ts: remove saveProxyUrl, the proxy_url field, and its logout preservation. - const.ts: PROXY_URL() now just returns BACKEND_URL (override branch and the proxy_url field gone). - Tests: prune the saveProxyUrl / PROXY_URL-override cases, the advanceThroughProxyUrl seam, and the hidden-step test; fix a stale ConfigApp comment and the AGENTS.md flow reference. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
With the override gone, PROXY_URL() was just a wrapper returning the BACKEND_URL constant. Remove the indirection: inline BACKEND_URL at the three proxy.ts call sites (auth/exchange, config, supabase/exchange) and drop the function. Update const.test.ts (remove the now-defunct PROXY_URL describe) and proxy.test.ts (build expected URLs from BACKEND_URL). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Choose proxy URL" step in
codev install/codev configwas fully wired up but permanently disabled via theSHOW_PROXY_URL_STEP = falseflag — it never rendered and never persisted anything. This removes it end to end: the TUI, the SetupApp orchestration, and the persistence/consumption plumbing that existed only to serve it.Changes
Deleted
src/components/ProxyUrl.tsx+tests/components/ProxyUrl.test.tsxsrc/SetupApp.tsx"proxy-url"phase,SHOW_PROXY_URL_STEP, thePOST_INSTALLgate array,proxyChoice/pendingSurvivorsstate,handleProxyUrlConfirm, the auto-advanceuseEffect, and theProxyUrl<Step>.handleLoginDone/handleInstallDonenow callrunPostInstallSideEffectsdirectly with the survivor set instead of parking it and routing through the picker.src/lib/auth.tssaveProxyUrl, theproxy_urlfield, and its preservation inlogout.src/lib/const.tsPROXY_URL()now simply returnsBACKEND_URL(override branch +proxy_urlfield gone).Tests & docs
saveProxyUrl/PROXY_URL-override cases, theadvanceThroughProxyUrlseam and its call sites, and the hidden-step test.ConfigApp.test.tsxcomment and theAGENTS.mdflow reference.Net:
32 insertions(+), 760 deletions(-).Validation
pnpm fix— cleanpnpm typecheck— cleanpnpm test— 722 passed / 50 filespnpm build && node dist/index.js --version→0.3.7🤖 Generated with Claude Code