fix(quickget): add hash verification for Archcraft, KolibriOS, Mabox#1806
Merged
flexiondotorg merged 4 commits intomasterfrom Jan 24, 2026
Merged
fix(quickget): add hash verification for Archcraft, KolibriOS, Mabox#1806flexiondotorg merged 4 commits intomasterfrom
flexiondotorg merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- Checksum URL in
quickgetprependsvto${RELEASE}while the download path uses${RELEASE}; withlatestthis becomesvlatest, so checksum fetch likely fails and could break downloads. - Given the medium severity and likely user-impacting failure in checksum retrieval, there is some merge risk to address before shipping.
- Pay close attention to
quickget- align the checksum URL with the release path to avoid fetch failures.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickget">
<violation number="1" location="quickget:1608">
P2: The hash URL adds a `v` prefix (`v${RELEASE}`) that doesn't match the download path used above (`${RELEASE}`). With `releases_archcraft` returning `latest`, this becomes `vlatest`, so the checksum fetch will likely fail and HASH will be empty. Use the same release path as the download URL.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
The hash URL was incorrectly using 'v${RELEASE}' (e.g., 'vlatest')
instead of extracting the actual version folder from the redirect URL.
Since releases_archcraft returns 'latest', the download redirect goes
to a versioned folder like 'v25.10', but the hash file lookup used
'vlatest' which doesn't exist.
Extract the version folder from the redirect URL to construct the
correct hash file path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add checksum retrieval to quickget for distros that previously lacked hash verification. This ensures downloaded ISOs can be verified before use.
Changes
Testing
./quickget --check <distro> <release>to validate URL and checksum parsingFixes #1545