Skip to content

fix(quickget): add hash verification for Archcraft, KolibriOS, Mabox#1806

Merged
flexiondotorg merged 4 commits intomasterfrom
hashes
Jan 24, 2026
Merged

fix(quickget): add hash verification for Archcraft, KolibriOS, Mabox#1806
flexiondotorg merged 4 commits intomasterfrom
hashes

Conversation

@flexiondotorg
Copy link
Member

Summary

Add checksum retrieval to quickget for distros that previously lacked hash verification. This ensures downloaded ISOs can be verified before use.

Changes

  • quickget: add SHA256 retrieval for Archcraft (SourceForge .sha256sum)
  • quickget: add SHA256 retrieval for KolibriOS (sha256sums.txt)
  • quickget: add MD5 retrieval for Mabox Linux (repo.maboxlinux.org .md5)

Testing

  • Run ./quickget --check <distro> <release> to validate URL and checksum parsing

Fixes #1545

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 3/5

  • Checksum URL in quickget prepends v to ${RELEASE} while the download path uses ${RELEASE}; with latest this becomes vlatest, so checksum fetch likely fails and could break downloads.
  • Given the medium severity and likely user-impacting failure in checksum retrieval, there is some merge risk to address before shipping.
  • Pay close attention to quickget - align the checksum URL with the release path to avoid fetch failures.
Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="quickget">

<violation number="1" location="quickget:1608">
P2: The hash URL adds a `v` prefix (`v${RELEASE}`) that doesn't match the download path used above (`${RELEASE}`). With `releases_archcraft` returning `latest`, this becomes `vlatest`, so the checksum fetch will likely fail and HASH will be empty. Use the same release path as the download URL.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

The hash URL was incorrectly using 'v${RELEASE}' (e.g., 'vlatest')
instead of extracting the actual version folder from the redirect URL.
Since releases_archcraft returns 'latest', the download redirect goes
to a versioned folder like 'v25.10', but the hash file lookup used
'vlatest' which doesn't exist.

Extract the version folder from the redirect URL to construct the
correct hash file path.
@flexiondotorg flexiondotorg merged commit c66827c into master Jan 24, 2026
93 of 95 checks passed
@flexiondotorg flexiondotorg deleted the hashes branch January 24, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: extend HASH coverage of OSes

1 participant