feat(quickemu): enable GL on macOS (cocoa) and prefer virtio GL#1812
Merged
flexiondotorg merged 2 commits intomasterfrom Jan 24, 2026
Merged
feat(quickemu): enable GL on macOS (cocoa) and prefer virtio GL#1812flexiondotorg merged 2 commits intomasterfrom
flexiondotorg merged 2 commits intomasterfrom
Conversation
- Add check_cocoa_gl_es_support(): detect QEMU cocoa gl=es support and look for ANGLE/libEGL in QEMU prefix, Homebrew and DYLD paths - Use the check in configure_display() to enable "gl=es" for cocoa when available and fall back to disabling GL (preserving previous stability behaviour) - Improve virtio GL selection: prefer virtio-gpu(-gl) / virtio-gpu-gl-pci / virtio-vga-gl variants when GL is enabled and QEMU exposes the device - Remove the hard disable of GL for cocoa in display_param_check() (now handled by the detection function) - Ensure user-visible display/GL/VirGL status remains printed for diagnostics Enables safer GL usage on macOS (covers Nix/Homebrew QEMU and ANGLE cases); falls back cleanly when support is absent. Signed-off-by: Martin Wimpress <martin@wimpress.org>
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- Portability risk:
quickemuusesgrepwith\|in BRE, which fails on macOS without-E, so pattern matching may break for macOS users. - Score reflects a concrete cross-platform behavior issue with medium severity, though it’s localized and straightforward to fix.
- Pay close attention to
quickemu- grep alternation should use-Efor macOS compatibility.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickemu">
<violation number="1" location="quickemu:968">
P1: BSD grep on macOS doesn't support `\|` alternation in BRE. Use `-E` flag for extended regex to ensure the pattern works correctly on macOS.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANGLE/libEGL in QEMU prefix, Homebrew and DYLD paths
and fall back to disabling GL (preserving previous stability behaviour)
virtio-vga-gl variants when GL is enabled and QEMU exposes the device
by the detection function)
Enables safer GL usage on macOS (covers Nix/Homebrew QEMU and ANGLE cases);
falls back cleanly when support is absent.
Type of change
Checklist: