Skip to content

fix(quickemu): set xres/yres only for devices that support them#1818

Merged
flexiondotorg merged 1 commit intomasterfrom
res-fix
Jan 24, 2026
Merged

fix(quickemu): set xres/yres only for devices that support them#1818
flexiondotorg merged 1 commit intomasterfrom
res-fix

Conversation

@flexiondotorg
Copy link
Member

  • Replace vmware-svga exclusion with explicit device regex
  • Apply xres/yres only to virtio-(vga|vga-gl|gpu|gpu-pci|gpu-gl-pci), qxl, qxl-vga and bochs-display
  • Prevent passing unsupported xres/yres params to other display devices, avoiding incorrect resolution coercion and QEMU warnings

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 4/5

  • This PR looks safe to merge overall; the main issue is a small, non-blocking logic gap rather than a critical defect.
  • quickemu’s device regex omits virtio-gpu-gl, so when GL is enabled the resolution parameters are skipped even though the device supports them, which could lead to unexpected display settings.
  • Pay close attention to quickemu - update the device regex to include virtio-gpu-gl so xres/yres are applied.
Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="quickemu">

<violation number="1" location="quickemu:1304">
P2: The device regex excludes "virtio-gpu-gl", so when GL is enabled and DISPLAY_DEVICE becomes virtio-gpu-gl, xres/yres are skipped even though the device supports them. Include virtio-gpu-gl in the allowed list.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

- Replace vmware-svga exclusion with explicit device regex
- Apply xres/yres only to virtio-(vga|vga-gl|gpu|gpu-pci|gpu-gl-pci),
qxl, qxl-vga and bochs-display
- Prevent passing unsupported xres/yres params to other display devices,
avoiding incorrect resolution coercion and QEMU warnings

Signed-off-by: Martin Wimpress <martin@wimpress.org>
@flexiondotorg
Copy link
Member Author

@cubic-dev-ai

@cubic-dev-ai
Copy link
Contributor

cubic-dev-ai bot commented Jan 24, 2026

@cubic-dev-ai

@flexiondotorg I have started the AI code review. It will take a few minutes to complete.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@flexiondotorg flexiondotorg merged commit 5276eba into master Jan 24, 2026
3 of 5 checks passed
@flexiondotorg flexiondotorg deleted the res-fix branch January 24, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant