fix(quickemu): set xres/yres only for devices that support them#1818
Merged
flexiondotorg merged 1 commit intomasterfrom Jan 24, 2026
Merged
fix(quickemu): set xres/yres only for devices that support them#1818flexiondotorg merged 1 commit intomasterfrom
flexiondotorg merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- This PR looks safe to merge overall; the main issue is a small, non-blocking logic gap rather than a critical defect.
quickemu’s device regex omitsvirtio-gpu-gl, so when GL is enabled the resolution parameters are skipped even though the device supports them, which could lead to unexpected display settings.- Pay close attention to
quickemu- update the device regex to includevirtio-gpu-glso xres/yres are applied.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickemu">
<violation number="1" location="quickemu:1304">
P2: The device regex excludes "virtio-gpu-gl", so when GL is enabled and DISPLAY_DEVICE becomes virtio-gpu-gl, xres/yres are skipped even though the device supports them. Include virtio-gpu-gl in the allowed list.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Replace vmware-svga exclusion with explicit device regex - Apply xres/yres only to virtio-(vga|vga-gl|gpu|gpu-pci|gpu-gl-pci), qxl, qxl-vga and bochs-display - Prevent passing unsupported xres/yres params to other display devices, avoiding incorrect resolution coercion and QEMU warnings Signed-off-by: Martin Wimpress <martin@wimpress.org>
19808de to
877a034
Compare
Member
Author
Contributor
|
@flexiondotorg I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist: