Skip to content

refactor: quote expansions and add ShellCheck directive#1821

Merged
flexiondotorg merged 1 commit intomasterfrom
shellcheck
Jan 25, 2026
Merged

refactor: quote expansions and add ShellCheck directive#1821
flexiondotorg merged 1 commit intomasterfrom
shellcheck

Conversation

@flexiondotorg
Copy link
Member

  • Quote URL argument passed to web_pipe in quickget to prevent word-splitting
  • Quote echoed variables in quickget (echo "${...}") for safe output when values contain whitespace
  • Add shellcheck disable=SC2054 in quickemu vm_boot to silence a spurious ShellCheck warning

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code

- Quote URL argument passed to web_pipe in quickget to prevent
word-splitting
- Quote echoed variables in quickget (echo "${...}") for safe output
when values contain whitespace
- Add shellcheck disable=SC2054 in quickemu vm_boot to silence a
spurious ShellCheck warning

Signed-off-by: Martin Wimpress <martin@wimpress.org>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@flexiondotorg flexiondotorg merged commit 2324d96 into master Jan 25, 2026
93 of 96 checks passed
@flexiondotorg flexiondotorg deleted the shellcheck branch January 25, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant