perf(quickemu): tune TCG translation cache and enable multithreaded TCG#1824
Merged
flexiondotorg merged 1 commit intomasterfrom Jan 25, 2026
Merged
perf(quickemu): tune TCG translation cache and enable multithreaded TCG#1824flexiondotorg merged 1 commit intomasterfrom
flexiondotorg merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 5/5
- Minor style consistency issue:
TCG_TB_SIZEshould be declaredlocallikeHOST_RAM_GB, but this is low severity and unlikely to affect behavior. - Low-impact housekeeping only, so merge risk appears minimal.
- Pay close attention to
quickemu- ensureTCG_TB_SIZEis declaredlocalfor consistency.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickemu">
<violation number="1" location="quickemu:1681">
P3: `TCG_TB_SIZE` should be declared as `local` for consistency with `HOST_RAM_GB` and the codebase's pattern of using local variables in functions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Add TCG-specific runtime optimisations in vm_boot for
cross-architecture VMs
- Detect host RAM and set tb-size to 512 for hosts with >=16GB,
otherwise 256
- Append -accel tcg,tb-size=${TCG_TB_SIZE},thread=multi to QEMU args
- Improve TCG translation cache behaviour and SMP performance for TCG
guests
Signed-off-by: Martin Wimpress <martin@wimpress.org>
Member
Author
Contributor
|
@flexiondotorg I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist: