fix(quickemu): enable vmware TSC and disable ACPI PCI hotplug for macOS#1827
Merged
flexiondotorg merged 2 commits intomasterfrom Jan 25, 2026
Merged
fix(quickemu): enable vmware TSC and disable ACPI PCI hotplug for macOS#1827flexiondotorg merged 2 commits intomasterfrom
flexiondotorg merged 2 commits intomasterfrom
Conversation
- Pass vmware-cpuid-freq=on to -cpu on Intel hosts to enable VMware TSC frequency reporting and improve macOS timing - Add ICH9-LPC flag to disable ACPI PCI hotplug bridge support to avoid macOS PCI hotplug issues (required for QEMU 6.1+) Signed-off-by: Martin Wimpress <martin@wimpress.org>
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- The unconditional addition of the ICH9-LPC hotplug flag in
quickemucan cause QEMU startup failures on older versions that lack the property, which is a concrete user-facing regression. - Score reflects a medium-severity compatibility risk (6/10) with a clear failure mode, though limited to older QEMU environments.
- Pay close attention to
quickemu- guard or version-check the ICH9-LPC hotplug flag to avoid startup failures on older QEMU.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickemu">
<violation number="1" location="quickemu:683">
P2: The new ICH9-LPC hotplug flag is added unconditionally, but older QEMU versions don’t expose `ICH9-LPC.acpi-pci-hotplug-with-bridge-support`. This causes QEMU startup to fail with “Property ... not found” on those versions. Guard the flag behind a QEMU version check (>= 6.1) and keep the previous args for older builds.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Raise global minimum QEMU version from 6.0.0 to 6.1.0. - The option -global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off used for macOS guests is only available in QEMU 6.1.0 and later; prefer raising the global requirement rather than adding per-flag conditionals. - Update version check and error message in quickemu. BREAKING CHANGE: Require QEMU 6.1.0; older QEMU will fail the version check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist: