Skip to content

fix(quickemu): enable vmware TSC and disable ACPI PCI hotplug for macOS#1827

Merged
flexiondotorg merged 2 commits intomasterfrom
macos-cpu
Jan 25, 2026
Merged

fix(quickemu): enable vmware TSC and disable ACPI PCI hotplug for macOS#1827
flexiondotorg merged 2 commits intomasterfrom
macos-cpu

Conversation

@flexiondotorg
Copy link
Member

  • Pass vmware-cpuid-freq=on to -cpu on Intel hosts to enable VMware TSC frequency reporting and improve macOS timing
  • Add ICH9-LPC flag to disable ACPI PCI hotplug bridge support to avoid macOS PCI hotplug issues (required for QEMU 6.1+)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code

- Pass vmware-cpuid-freq=on to -cpu on Intel hosts to enable VMware TSC
  frequency reporting and improve macOS timing
- Add ICH9-LPC flag to disable ACPI PCI hotplug bridge support to avoid
  macOS PCI hotplug issues (required for QEMU 6.1+)

Signed-off-by: Martin Wimpress <martin@wimpress.org>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 3/5

  • The unconditional addition of the ICH9-LPC hotplug flag in quickemu can cause QEMU startup failures on older versions that lack the property, which is a concrete user-facing regression.
  • Score reflects a medium-severity compatibility risk (6/10) with a clear failure mode, though limited to older QEMU environments.
  • Pay close attention to quickemu - guard or version-check the ICH9-LPC hotplug flag to avoid startup failures on older QEMU.
Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="quickemu">

<violation number="1" location="quickemu:683">
P2: The new ICH9-LPC hotplug flag is added unconditionally, but older QEMU versions don’t expose `ICH9-LPC.acpi-pci-hotplug-with-bridge-support`. This causes QEMU startup to fail with “Property ... not found” on those versions. Guard the flag behind a QEMU version check (>= 6.1) and keep the previous args for older builds.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

- Raise global minimum QEMU version from 6.0.0 to 6.1.0.
- The option -global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off used for macOS guests
  is only available in QEMU 6.1.0 and later; prefer raising the global requirement rather
  than adding per-flag conditionals.
- Update version check and error message in quickemu.

BREAKING CHANGE: Require QEMU 6.1.0; older QEMU will fail the version check.
@flexiondotorg flexiondotorg merged commit 64eedfe into master Jan 25, 2026
4 of 5 checks passed
@flexiondotorg flexiondotorg deleted the macos-cpu branch January 25, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant