fix(quickemu): remove integrated OpenCore support, require OpenCore.qcow2#1844
Merged
flexiondotorg merged 1 commit intomasterfrom Jan 26, 2026
Merged
fix(quickemu): remove integrated OpenCore support, require OpenCore.qcow2#1844flexiondotorg merged 1 commit intomasterfrom
flexiondotorg merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 4/5
- Small risk: the only issue is a low-severity (4/10) error-reporting bug that could mask a prior firmware error message.
- In
quickemu, overwritingMAC_MISSINGcan hide an existing "Firmware" error when both firmware and bootloader are missing, which could mislead users during troubleshooting. - Pay close attention to
quickemu- preserve existing error state when settingMAC_MISSING.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickemu">
<violation number="1" location="quickemu:924">
P2: This unconditionally overwrites `MAC_MISSING`, hiding a previous "Firmware" error. If both firmware and bootloader are missing, only "Bootloader" error is shown. Consider preserving existing errors:
```bash
[ -z "${MAC_MISSING}" ] && MAC_MISSING="Bootloader"
```</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| # No separate bootloader file needed | ||
| MAC_BOOTLOADER="" | ||
| MAC_BOOT_MODE="integrated" | ||
| MAC_MISSING="Bootloader" |
Contributor
There was a problem hiding this comment.
P2: This unconditionally overwrites MAC_MISSING, hiding a previous "Firmware" error. If both firmware and bootloader are missing, only "Bootloader" error is shown. Consider preserving existing errors:
[ -z "${MAC_MISSING}" ] && MAC_MISSING="Bootloader"Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At quickemu, line 924:
<comment>This unconditionally overwrites `MAC_MISSING`, hiding a previous "Firmware" error. If both firmware and bootloader are missing, only "Bootloader" error is shown. Consider preserving existing errors:
```bash
[ -z "${MAC_MISSING}" ] && MAC_MISSING="Bootloader"
```</comment>
<file context>
@@ -915,32 +915,21 @@ function configure_bios() {
- # No separate bootloader file needed
- MAC_BOOTLOADER=""
- MAC_BOOT_MODE="integrated"
+ MAC_MISSING="Bootloader"
fi
</file context>
Suggested change
| MAC_MISSING="Bootloader" | |
| [ -z "${MAC_MISSING}" ] && MAC_MISSING="Bootloader" |
…cow2 - Remove integrated OpenCore creation/extraction code from quickget: require_mtools/sgdisk helpers, create_macos_disk_with_opencore, download_opencore and related logic - Simplify quickemu macOS boot flow to expect a separate OpenCore.qcow2 or ESP.qcow2; streamline device/drive argument construction - Remove mtools and gptfdisk from devshell.nix and package.nix - Always download OpenCore.qcow2 via legacy method and update status messages Signed-off-by: Martin Wimpress <martin@wimpress.org>
1cbab1d to
9fa3de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist: